Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-26 Thread Diego Elio Pettenò
On Sun, Aug 25, 2019 at 11:13 PM Joe Perches wrote: > > - cd_dbg(CD_OPEN, "entering register_cdrom\n"); > > + pr_debug("entering register_cdrom\n"); > > debut output for function tracing can also be removed > and ftrace used instead. Oh, nice! I have never had to go this deep into a drive

Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-25 Thread Joe Perches
On Sun, 2019-08-25 at 22:58 +0100, Diego Elio Pettenò wrote: > The cdrom driver predates debugfs and most of the modern debugging > facilities, so instead it has been includings a module parameter and an > ioctl to enable debug messages. > > In 2019, debugfs and dynamic debug makes most of that re

[PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

2019-08-25 Thread Diego Elio Pettenò
The cdrom driver predates debugfs and most of the modern debugging facilities, so instead it has been includings a module parameter and an ioctl to enable debug messages. In 2019, debugfs and dynamic debug makes most of that redundant, and even confusing when trying to trace things in the dept of