Re: [PATCH] cdrom_sysctl_info fix

2007-06-18 Thread Jens Axboe
On Mon, Jun 18 2007, dave young wrote: > Hi, > >> BTW, another problem, I can't find the CONFIG_CDROM option in kernel > >> config menu. Is it deperacated? If it is true, is the module part > >> still necessary? > > > >cdrom.o is a hardware independent helper module, it gets included if you > >use

Re: [PATCH] cdrom_sysctl_info fix

2007-06-18 Thread dave young
Hi, > BTW, another problem, I can't find the CONFIG_CDROM option in kernel > config menu. Is it deperacated? If it is true, is the module part > still necessary? cdrom.o is a hardware independent helper module, it gets included if you use atapi/scsi/etc cdrom drivers. See drivers/cdrom/Makefile.

Re: [PATCH] cdrom_sysctl_info fix

2007-06-17 Thread Jens Axboe
On Mon, Jun 18 2007, dave young wrote: > Hi, > >Yep that looks much better! I trust you booted and tested this and the > >output looks correct? > Yes, I tested and the output is correct. Good > BTW, another problem, I can't find the CONFIG_CDROM option in kernel > config menu. Is it deperacated?

Re: [PATCH] cdrom_sysctl_info fix

2007-06-17 Thread dave young
Hi, Yep that looks much better! I trust you booted and tested this and the output looks correct? Yes, I tested and the output is correct. BTW, another problem, I can't find the CONFIG_CDROM option in kernel config menu. Is it deperacated? If it is true, is the module part still necessary? Rega

Re: [PATCH] cdrom_sysctl_info fix

2007-06-17 Thread Jens Axboe
On Mon, Jun 18 2007, Dave Young wrote: > I rewite the patch according to yours, please help to check. Pass the > cdrom_print_info function one more argument for diffrent type > printing, do you have better solutions for this? thanks for replying > :) Yep that looks much better! I trust you booted

Re: [PATCH] cdrom_sysctl_info fix

2007-06-17 Thread Dave Young
Hi jens, Thanks for rework this patch.But it has some bugs, results kernel oops. On Fri, Jun 15, 2007 at 03:26:57PM +0200, Jens Axboe wrote: > On Thu, Jun 14 2007, Dave Young wrote: > > Hi, > > > > Fix the cdrom_sysctl_info possible buffer overwrite bug. Somd > > codingstyle fixes are included as

Re: [PATCH] cdrom_sysctl_info fix

2007-06-15 Thread Jens Axboe
On Thu, Jun 14 2007, Dave Young wrote: > Hi, > > Fix the cdrom_sysctl_info possible buffer overwrite bug. Somd > codingstyle fixes are included as well. How about something like this? The current code is actually racy, because there's no protection against adding/removing a cdrom while it runs.

Re: [PATCH] cdrom_sysctl_info fix

2007-06-14 Thread Dave Young
Hi, >On Fri, Jun 15, 2007 at 07:58:47AM +0200, Jens Axboe wrote: > Hey, no point in CC'ing me twice! [EMAIL PROTECTED] works just fine as > well. > I'm sorry for it , jens. Now I resend the patch after remove some checkpatch.pl warnings(line breaking trailing space). If user have many cdrom dri

Re: [PATCH] cdrom_sysctl_info fix

2007-06-14 Thread Jens Axboe
On Fri, Jun 15 2007, dave young wrote: > Hi, > >Better to use the email address in the MAINTAINERS file than > >the one in the driver source file. > > Really? I searched the list, found axboe use the address > [EMAIL PROTECTED], same as what andrew said. does the MAINTAINERS > file be updated? He

Re: [PATCH] cdrom_sysctl_info fix

2007-06-14 Thread Randy Dunlap
dave young wrote: Hi, Better to use the email address in the MAINTAINERS file than the one in the driver source file. Really? I searched the list, found axboe use the address [EMAIL PROTECTED], same as what andrew said. does the MAINTAINERS file be updated? Could be, but that's up to Jens.

Re: [PATCH] cdrom_sysctl_info fix

2007-06-14 Thread dave young
Hi, Better to use the email address in the MAINTAINERS file than the one in the driver source file. Really? I searched the list, found axboe use the address [EMAIL PROTECTED], same as what andrew said. does the MAINTAINERS file be updated? Regards dave - To unsubscribe from this list: send the

Re: [PATCH] cdrom_sysctl_info fix

2007-06-14 Thread Randy Dunlap
On Thu, 14 Jun 2007 06:40:49 + dave young wrote: > Hi Andrew, > > Sorry for reply to myself, does the Jens Axboe's email is outdated? > which one is the latest? > > And Jens, could you please update your email address? Better to use the email address in the MAINTAINERS file than the one i

Re: [PATCH] cdrom_sysctl_info fix

2007-06-13 Thread dave young
Hi Andrew, Sorry for reply to myself, does the Jens Axboe's email is outdated? which one is the latest? And Jens, could you please update your email address? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo i

[PATCH] cdrom_sysctl_info fix

2007-06-13 Thread Dave Young
Hi, Fix the cdrom_sysctl_info possible buffer overwrite bug. Somd codingstyle fixes are included as well. diff based on 2.6.22-rc4 Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- drivers/cdrom/cdrom.c | 186 +- 1 files changed, 102 insertions(+), 84 deletions(-) diff -upr linux/drivers/cdrom