Re: [PATCH] ceph: Fix an Oops in error handling

2021-02-02 Thread Dan Carpenter
On Tue, Feb 02, 2021 at 07:37:57AM -0500, Jeff Layton wrote: > On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote: > > The "req" pointer is an error pointer and not NULL so this check needs > > to be fixed. > > > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > > Signe

Re: [PATCH] ceph: fix an oops in error handling in ceph_netfs_issue_op

2021-02-02 Thread Dan Carpenter
On Tue, Feb 02, 2021 at 08:10:41AM -0500, Jeff Layton wrote: > Dan reported a potential oops in the cleanup if ceph_osdc_new_request > returns an error. Eliminate the unneeded initialization of "req" and > then just set it to NULL in the case where it holds an ERR_PTR. > > Also, drop the unneeded

[PATCH] ceph: fix an oops in error handling in ceph_netfs_issue_op

2021-02-02 Thread Jeff Layton
Dan reported a potential oops in the cleanup if ceph_osdc_new_request returns an error. Eliminate the unneeded initialization of "req" and then just set it to NULL in the case where it holds an ERR_PTR. Also, drop the unneeded NULL check before calling ceph_osdc_put_request. Fixes: 1cf7fdf52d5a (

Re: [PATCH] ceph: Fix an Oops in error handling

2021-02-02 Thread Jeff Layton
On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote: > The "req" pointer is an error pointer and not NULL so this check needs > to be fixed. > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > Signed-off-by: Dan Carpenter > --- >  fs/ceph/addr.c | 2 +- >  1 file changed

Re: [PATCH] ceph: Fix an Oops in error handling

2021-02-02 Thread Ilya Dryomov
On Tue, Feb 2, 2021 at 6:47 AM Dan Carpenter wrote: > > The "req" pointer is an error pointer and not NULL so this check needs > to be fixed. > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > Signed-off-by: Dan Carpenter > --- > fs/ceph/addr.c | 2 +- > 1 file changed,

[PATCH] ceph: Fix an Oops in error handling

2021-02-01 Thread Dan Carpenter
The "req" pointer is an error pointer and not NULL so this check needs to be fixed. Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") Signed-off-by: Dan Carpenter --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ceph/addr.c b/fs/ceph/a