Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-18 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 8:40 PM, Luis Henriques wrote: > Ilya Dryomov writes: > >> On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >>> Luis Henriques writes: >>> When a user requests SEEK_HOLE or

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-18 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 8:40 PM, Luis Henriques wrote: > Ilya Dryomov writes: > >> On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >>> Luis Henriques writes: >>> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset ceph_llseek should return -ENXIO. Currently

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Luis Henriques
Ilya Dryomov writes: > On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >> Luis Henriques writes: >> >>> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >>> ceph_llseek should return -ENXIO. Currently

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Luis Henriques
Ilya Dryomov writes: > On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >> Luis Henriques writes: >> >>> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >>> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >>> SEEK_DATA and 0 for SEEK_HOLE. >>

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: > Luis Henriques writes: > >> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >> SEEK_DATA and 0 for

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Ilya Dryomov
On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: > Luis Henriques writes: > >> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >> SEEK_DATA and 0 for SEEK_HOLE. > > Ping > > This patch should

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Luis Henriques
Luis Henriques writes: > When a user requests SEEK_HOLE or SEEK_DATA with a negative offset > ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for > SEEK_DATA and 0 for SEEK_HOLE. Ping This patch should make xfstest generic/448 happy. Cheers, --

Re: [PATCH] ceph: check negative offsets on ceph_llseek()

2017-08-17 Thread Luis Henriques
Luis Henriques writes: > When a user requests SEEK_HOLE or SEEK_DATA with a negative offset > ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for > SEEK_DATA and 0 for SEEK_HOLE. Ping This patch should make xfstest generic/448 happy. Cheers, -- Luís > > Signed-off-by:

[PATCH] ceph: check negative offsets on ceph_llseek()

2017-07-28 Thread Luis Henriques
When a user requests SEEK_HOLE or SEEK_DATA with a negative offset ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for SEEK_DATA and 0 for SEEK_HOLE. Signed-off-by: Luis Henriques --- fs/ceph/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] ceph: check negative offsets on ceph_llseek()

2017-07-28 Thread Luis Henriques
When a user requests SEEK_HOLE or SEEK_DATA with a negative offset ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for SEEK_DATA and 0 for SEEK_HOLE. Signed-off-by: Luis Henriques --- fs/ceph/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git