Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-19 Thread Jeff Layton
On Tue, 2020-05-19 at 07:00 +0300, Amir Goldstein wrote: > On Tue, May 19, 2020 at 1:30 AM Gregory Farnum wrote: > > Maybe we resolved this conversation; I can't quite tell... > > I think v2 patch wraps it up... > > [...] > Agreed. > > > > Questions: > > > > 1. Does sync() result in fully pur

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-18 Thread Amir Goldstein
On Tue, May 19, 2020 at 1:30 AM Gregory Farnum wrote: > > Maybe we resolved this conversation; I can't quite tell... I think v2 patch wraps it up... [...] > > > > > > Questions: > > > 1. Does sync() result in fully purging inodes on MDS? > > > > I don't think so, but again, that code is not tri

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-18 Thread Gregory Farnum
Maybe we resolved this conversation; I can't quite tell... On Fri, May 15, 2020 at 12:16 PM Jeff Layton wrote: > > On Fri, 2020-05-15 at 19:56 +0300, Amir Goldstein wrote: > > On Fri, May 15, 2020 at 2:38 PM Jeff Layton wrote: > > > On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > > >

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-16 Thread Jeff Layton
On Sat, 2020-05-16 at 09:58 +0300, Amir Goldstein wrote: > [pulling in nfs guys] > > > > Questions: > > > 1. Does sync() result in fully purging inodes on MDS? > > > > I don't think so, but again, that code is not trivial to follow. I do > > know that the MDS keeps around a "strays directory" whi

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-15 Thread Amir Goldstein
[pulling in nfs guys] > > Questions: > > 1. Does sync() result in fully purging inodes on MDS? > > I don't think so, but again, that code is not trivial to follow. I do > know that the MDS keeps around a "strays directory" which contains > unlinked inodes that are lazily cleaned up. My suspicion i

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-15 Thread Jeff Layton
On Fri, 2020-05-15 at 19:56 +0300, Amir Goldstein wrote: > On Fri, May 15, 2020 at 2:38 PM Jeff Layton wrote: > > On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > > > On Fri, May 15, 2020 at 09:42:24AM +0300, Amir Goldstein wrote: > > > > +CC: fstests > > > > > > > > On Thu, May 14, 202

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-15 Thread Amir Goldstein
On Fri, May 15, 2020 at 2:38 PM Jeff Layton wrote: > > On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > > On Fri, May 15, 2020 at 09:42:24AM +0300, Amir Goldstein wrote: > > > +CC: fstests > > > > > > On Thu, May 14, 2020 at 4:15 PM Jeff Layton wrote: > > > > On Thu, 2020-05-14 at 13:48

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-15 Thread Jeff Layton
On Fri, 2020-05-15 at 12:15 +0100, Luis Henriques wrote: > On Fri, May 15, 2020 at 09:42:24AM +0300, Amir Goldstein wrote: > > +CC: fstests > > > > On Thu, May 14, 2020 at 4:15 PM Jeff Layton wrote: > > > On Thu, 2020-05-14 at 13:48 +0100, Luis Henriques wrote: > > > > On Thu, May 14, 2020 at 08:

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-15 Thread Luis Henriques
On Fri, May 15, 2020 at 09:42:24AM +0300, Amir Goldstein wrote: > +CC: fstests > > On Thu, May 14, 2020 at 4:15 PM Jeff Layton wrote: > > > > On Thu, 2020-05-14 at 13:48 +0100, Luis Henriques wrote: > > > On Thu, May 14, 2020 at 08:10:09AM -0400, Jeff Layton wrote: > > > > On Thu, 2020-05-14 at 1

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-14 Thread Amir Goldstein
+CC: fstests On Thu, May 14, 2020 at 4:15 PM Jeff Layton wrote: > > On Thu, 2020-05-14 at 13:48 +0100, Luis Henriques wrote: > > On Thu, May 14, 2020 at 08:10:09AM -0400, Jeff Layton wrote: > > > On Thu, 2020-05-14 at 12:14 +0100, Luis Henriques wrote: > > > > Similarly to commit 03f219041fdb ("c

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-14 Thread Jeff Layton
On Thu, 2020-05-14 at 13:48 +0100, Luis Henriques wrote: > On Thu, May 14, 2020 at 08:10:09AM -0400, Jeff Layton wrote: > > On Thu, 2020-05-14 at 12:14 +0100, Luis Henriques wrote: > > > Similarly to commit 03f219041fdb ("ceph: check i_nlink while converting > > > a file handle to dentry"), this fi

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-14 Thread Luis Henriques
On Thu, May 14, 2020 at 08:10:09AM -0400, Jeff Layton wrote: > On Thu, 2020-05-14 at 12:14 +0100, Luis Henriques wrote: > > Similarly to commit 03f219041fdb ("ceph: check i_nlink while converting > > a file handle to dentry"), this fixes another corner case with > > name_to_handle_at/open_by_handle

Re: [PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-14 Thread Jeff Layton
On Thu, 2020-05-14 at 12:14 +0100, Luis Henriques wrote: > Similarly to commit 03f219041fdb ("ceph: check i_nlink while converting > a file handle to dentry"), this fixes another corner case with > name_to_handle_at/open_by_handle_at. The issue has been detected by > xfstest generic/467, when doin

[PATCH] ceph: don't return -ESTALE if there's still an open file

2020-05-14 Thread Luis Henriques
Similarly to commit 03f219041fdb ("ceph: check i_nlink while converting a file handle to dentry"), this fixes another corner case with name_to_handle_at/open_by_handle_at. The issue has been detected by xfstest generic/467, when doing: - name_to_handle_at("/cephfs/myfile") - open("/cephfs/myfil