RE: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-13 Thread liujian (CE)
at; > linux-kernel@vger.kernel.org; joakim.tjernl...@infinera.com; > linux-...@lists.infradead.org; computersforpe...@gmail.com; > dw...@infradead.org; liujian (CE) ; > ikegami...@yahoo.co.jp > Subject: RE: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c > do_write_buffer > > Hi Pr

RE: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-08 Thread Tokunori Ikegami
inera.com; > linux-...@lists.infradead.org; computersforpe...@gmail.com; > dw...@infradead.org; Liu Jian > Subject: RE: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c > do_write_buffer > > Hi Ikegami, > > I have seen a case myself where a value was written, chip c

Re: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-08 Thread Joakim Tjernlund
On Thu, 2019-02-07 at 23:50 +, Sobon, Przemyslaw wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > Hi Ikegami, > > I have seen a case myself where a value

RE: Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-07 Thread Sobon, Przemyslaw
Hi Ikegami, I have seen a case myself where a value was written, chip changed state to "ready" but when I was reading the value was incorrect. This can happen as result of intermittent issue with flash. It is hard to fall into scenario when testing on limited number of devices but with large

Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-07 Thread Boris Brezillon
Hi Sobon, On Tue, 5 Feb 2019 22:28:44 + "Sobon, Przemyslaw" wrote: > > From: Boris Brezillon > > Sent: Sunday, February 3, 2019 12:35 AM > > > +Przemyslaw > > > > > > On Fri, 1 Feb 2019 07:30:39 +0800 > > > Liu Jian wrote: > > > > > > > In function do_write_buffer(), in the for

RE: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-05 Thread Sobon, Przemyslaw
> From: Boris Brezillon > Sent: Sunday, February 3, 2019 12:35 AM > > +Przemyslaw > > > > On Fri, 1 Feb 2019 07:30:39 +0800 > > Liu Jian wrote: > > > > > In function do_write_buffer(), in the for loop, there is a case > > > chip_ready() returns 1 while chip_good() returns 0, so it never > >

Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-03 Thread Boris Brezillon
On Sun, 3 Feb 2019 09:26:45 +0100 Boris Brezillon wrote: > +Przemyslaw > > On Fri, 1 Feb 2019 07:30:39 +0800 > Liu Jian wrote: > > > In function do_write_buffer(), in the for loop, there is a case > > chip_ready() returns 1 while chip_good() returns 0, so it never > > break the loop. > > To

Re: [PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-02-03 Thread Boris Brezillon
+Przemyslaw On Fri, 1 Feb 2019 07:30:39 +0800 Liu Jian wrote: > In function do_write_buffer(), in the for loop, there is a case > chip_ready() returns 1 while chip_good() returns 0, so it never > break the loop. > To fix this, chip_good() is enough and it should timeout if it stay > bad for a

[PATCH] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-01-31 Thread Liu Jian
In function do_write_buffer(), in the for loop, there is a case chip_ready() returns 1 while chip_good() returns 0, so it never break the loop. To fix this, chip_good() is enough and it should timeout if it stay bad for a while. Fixes: dfeae1073583(mtd: cfi_cmdset_0002: Change write buffer to