Re: [PATCH] cgroup: Remove unnecessary call to strstrip()

2021-01-15 Thread Tejun Heo
On Thu, Jan 14, 2021 at 01:44:27PM +0100, Michal Koutný wrote: > Hello. > > On Sun, Jan 03, 2021 at 02:50:01AM +, Hao Lee > wrote: > > The string buf will be stripped in cgroup_procs_write_start() before it > > is converted to int, so remove this unnecessary call to strstrip(). > Good

Re: [PATCH] cgroup: Remove unnecessary call to strstrip()

2021-01-14 Thread Hao Lee
> Perhaps the code be then simplified a bit > > -- >8 -- > From: =?UTF-8?q?Michal=20Koutn=C3=BD?= > Date: Thu, 14 Jan 2021 13:23:39 +0100 > Subject: [PATCH] cgroup: cgroup.{procs,threads} factor out common parts > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 >

Re: [PATCH] cgroup: Remove unnecessary call to strstrip()

2021-01-14 Thread Daniel Jordan
Hello Michal, Michal Koutný writes: > On Sun, Jan 03, 2021 at 02:50:01AM +, Hao Lee > wrote: >> The string buf will be stripped in cgroup_procs_write_start() before it >> is converted to int, so remove this unnecessary call to strstrip(). > Good catch, Hao. > > Perhaps the code be then

Re: [PATCH] cgroup: Remove unnecessary call to strstrip()

2021-01-14 Thread Michal Koutný
Hello. On Sun, Jan 03, 2021 at 02:50:01AM +, Hao Lee wrote: > The string buf will be stripped in cgroup_procs_write_start() before it > is converted to int, so remove this unnecessary call to strstrip(). Good catch, Hao. Perhaps the code be then simplified a bit -- >8 -- From:

[PATCH] cgroup: Remove unnecessary call to strstrip()

2021-01-02 Thread Hao Lee
The string buf will be stripped in cgroup_procs_write_start() before it is converted to int, so remove this unnecessary call to strstrip(). Signed-off-by: Hao Lee --- kernel/cgroup/cgroup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c

Re: [PATCH] cgroup: Remove unnecessary call to strstrip()

2020-10-01 Thread Hao Lee
Ping. Thanks. On Tue, Sep 08, 2020 at 01:33:50PM +, Hao Lee wrote: > The string buf will be stripped in cgroup_procs_write_start() before it > is converted to int, so remove this unnecessary call to strstrip(). > > Signed-off-by: Hao Lee > --- > kernel/cgroup/cgroup.c | 2 -- > 1 file

[PATCH] cgroup: Remove unnecessary call to strstrip()

2020-09-08 Thread Hao Lee
The string buf will be stripped in cgroup_procs_write_start() before it is converted to int, so remove this unnecessary call to strstrip(). Signed-off-by: Hao Lee --- kernel/cgroup/cgroup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c