Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-16 Thread Tejun Heo
Hello, On Tue, Jul 10, 2012 at 10:11:05AM +0800, Li Zefan wrote: > Right, but that should be safe. The css objects of the root cgroup are > allocated at boot, and won't be destroyed at umount. > > Furthermore when a cgroup hierarchy is going to be unmounted, those css's > will be made to point

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-16 Thread Tejun Heo
Hello, On Tue, Jul 10, 2012 at 10:11:05AM +0800, Li Zefan wrote: Right, but that should be safe. The css objects of the root cgroup are allocated at boot, and won't be destroyed at umount. Furthermore when a cgroup hierarchy is going to be unmounted, those css's will be made to point to a

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-09 Thread Li Zefan
On 2012/7/8 14:35, Tejun Heo wrote: > Hello, Li. > > On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote: >>> I think we're horridly broken for >>> root cgroup tho - and it has been broken for very long time. I think >>> it's mostly hidden because most (all?) controllers short-circuit root

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-09 Thread Li Zefan
On 2012/7/8 14:35, Tejun Heo wrote: Hello, Li. On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote: I think we're horridly broken for root cgroup tho - and it has been broken for very long time. I think it's mostly hidden because most (all?) controllers short-circuit root cgroup.

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-08 Thread Tejun Heo
Hello, Li. On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote: > > I think we're horridly broken for > > root cgroup tho - and it has been broken for very long time. I think > > it's mostly hidden because most (all?) controllers short-circuit root > > cgroup. Eh, well > > > > Could

Re: [PATCH] cgroup: fix dentry still in use bug when dropping css refs after umount

2012-07-08 Thread Tejun Heo
Hello, Li. On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote: I think we're horridly broken for root cgroup tho - and it has been broken for very long time. I think it's mostly hidden because most (all?) controllers short-circuit root cgroup. Eh, well Could you