Re: [PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-25 Thread Tejun Heo
On Sun, Jul 23, 2017 at 08:18:26AM -0400, Tejun Heo wrote: > cgroup_enable_threaded() checks that the cgroup doesn't have any tasks > or children and fails the operation if so. This test is unnecessary > because the first part is already checked by > cgroup_can_be_thread_root() and the latter is

Re: [PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-25 Thread Tejun Heo
On Sun, Jul 23, 2017 at 08:18:26AM -0400, Tejun Heo wrote: > cgroup_enable_threaded() checks that the cgroup doesn't have any tasks > or children and fails the operation if so. This test is unnecessary > because the first part is already checked by > cgroup_can_be_thread_root() and the latter is

Re: [PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-24 Thread Waiman Long
On 07/23/2017 08:18 AM, Tejun Heo wrote: > cgroup_enable_threaded() checks that the cgroup doesn't have any tasks > or children and fails the operation if so. This test is unnecessary > because the first part is already checked by > cgroup_can_be_thread_root() and the latter is unnecessary. The

Re: [PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-24 Thread Waiman Long
On 07/23/2017 08:18 AM, Tejun Heo wrote: > cgroup_enable_threaded() checks that the cgroup doesn't have any tasks > or children and fails the operation if so. This test is unnecessary > because the first part is already checked by > cgroup_can_be_thread_root() and the latter is unnecessary. The

[PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-23 Thread Tejun Heo
cgroup_enable_threaded() checks that the cgroup doesn't have any tasks or children and fails the operation if so. This test is unnecessary because the first part is already checked by cgroup_can_be_thread_root() and the latter is unnecessary. The latter actually cause a behavioral oddity.

[PATCH] cgroup: remove unnecessary empty check when enabling threaded mode

2017-07-23 Thread Tejun Heo
cgroup_enable_threaded() checks that the cgroup doesn't have any tasks or children and fails the operation if so. This test is unnecessary because the first part is already checked by cgroup_can_be_thread_root() and the latter is unnecessary. The latter actually cause a behavioral oddity.