Re: [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-22 Thread Jianyu Zhan
Hi, Li, On Tue, Apr 22, 2014 at 2:26 PM, Li Zefan wrote: > > I don't see this warning, and I don't see how this is possible. You are right. No such warning. It is triggered by the other patch, should be fixed in that patch. Thanks, Jianyu Zhan -- To unsubscribe from this list: send the

Re: [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-22 Thread Li Zefan
On 2014/4/22 13:44, Jianyu Zhan wrote: > To suppress this warning: > > warning: ‘err’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > int err; > ^ I don't see this warning, and I don't see how this is possible. static int create_css(struct cgroup *cgrp, struct

Re: [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-22 Thread Li Zefan
On 2014/4/22 13:44, Jianyu Zhan wrote: To suppress this warning: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] int err; ^ I don't see this warning, and I don't see how this is possible. static int create_css(struct cgroup *cgrp, struct

Re: [PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-22 Thread Jianyu Zhan
Hi, Li, On Tue, Apr 22, 2014 at 2:26 PM, Li Zefan lize...@huawei.com wrote: I don't see this warning, and I don't see how this is possible. You are right. No such warning. It is triggered by the other patch, should be fixed in that patch. Thanks, Jianyu Zhan -- To unsubscribe from this

[PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-21 Thread Jianyu Zhan
To suppress this warning: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] int err; ^ Use the uninitialized_var() to decalre err. It also serves to be good documetation. Signed-off-by: Jianyu Zhan --- kernel/cgroup.c | 2 +- 1 file changed, 1

[PATCH] cgroup: use uninitialized_var() for may-be uninitialized variable

2014-04-21 Thread Jianyu Zhan
To suppress this warning: warning: ‘err’ may be used uninitialized in this function [-Wmaybe-uninitialized] int err; ^ Use the uninitialized_var() to decalre err. It also serves to be good documetation. Signed-off-by: Jianyu Zhan nasa4...@gmail.com --- kernel/cgroup.c | 2 +- 1