Re: [PATCH] char: misc: minor code cleanup

2017-04-08 Thread Greg Kroah-Hartman
On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote: > Fix a couple of minor issues found by checkpatch.pl: > > Add/remove spaces where required. > Move EXPORT_SYMBOL() to the end of the function it refers to. > Set the access mode for the proc entry explicity. > Use pr_warn() instead

Re: [PATCH] char: misc: minor code cleanup

2017-04-08 Thread Greg Kroah-Hartman
On Mon, Feb 27, 2017 at 11:27:58PM +0100, Martin Kaiser wrote: > Fix a couple of minor issues found by checkpatch.pl: > > Add/remove spaces where required. > Move EXPORT_SYMBOL() to the end of the function it refers to. > Set the access mode for the proc entry explicity. > Use pr_warn() instead

[PATCH] char: misc: minor code cleanup

2017-02-27 Thread Martin Kaiser
Fix a couple of minor issues found by checkpatch.pl: Add/remove spaces where required. Move EXPORT_SYMBOL() to the end of the function it refers to. Set the access mode for the proc entry explicity. Use pr_warn() instead of printk() without loglevel. Signed-off-by: Martin Kaiser

[PATCH] char: misc: minor code cleanup

2017-02-27 Thread Martin Kaiser
Fix a couple of minor issues found by checkpatch.pl: Add/remove spaces where required. Move EXPORT_SYMBOL() to the end of the function it refers to. Set the access mode for the proc entry explicity. Use pr_warn() instead of printk() without loglevel. Signed-off-by: Martin Kaiser ---