Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Andrew Morton
On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. Should we also do this? ---

Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Andrew Morton
On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. Should we also do this? ---

Re: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 16:11 -0800, Kees Cook wrote: > On Tue, Feb 28, 2017 at 4:06 PM, Andrew Morton > wrote: > > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > > > > > %pK was at least once misused at %pk in an out-of-tree module. > > >

Re: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 16:11 -0800, Kees Cook wrote: > On Tue, Feb 28, 2017 at 4:06 PM, Andrew Morton > wrote: > > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > > > > > %pK was at least once misused at %pk in an out-of-tree module. > > > This lead to some security concerns. Add the

Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 16:06 -0800, Andrew Morton wrote: > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > > > %pK was at least once misused at %pk in an out-of-tree module. > > This lead to some security concerns. Add the ability to track > > single and multiple line

Re: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Kees Cook
On Tue, Feb 28, 2017 at 4:06 PM, Andrew Morton wrote: > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > >> %pK was at least once misused at %pk in an out-of-tree module. >> This lead to some security concerns. Add the ability to track >>

Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Joe Perches
On Tue, 2017-02-28 at 16:06 -0800, Andrew Morton wrote: > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > > > %pK was at least once misused at %pk in an out-of-tree module. > > This lead to some security concerns. Add the ability to track > > single and multiple line statements for

Re: [kernel-hardening] Re: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Kees Cook
On Tue, Feb 28, 2017 at 4:06 PM, Andrew Morton wrote: > On Mon, 27 Feb 2017 12:54:55 -0800 Joe Perches wrote: > >> %pK was at least once misused at %pk in an out-of-tree module. >> This lead to some security concerns. Add the ability to track >> single and multiple line statements for misuses

RE: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Roberts, William C
e...@intel.com>; kernel- > harden...@lists.openwall.com; linux-kernel@vger.kernel.org > Subject: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p > extensions > > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the abi

RE: [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-28 Thread Roberts, William C
checkpatch: Add ability to find bad uses of vsprintf %p > extensions > > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track single and > multiple > line statements for misuses of %p. > > Signed

Re: [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Kees Cook
On Mon, Feb 27, 2017 at 12:54 PM, Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. > > Signed-off-by: Joe Perches

Re: [kernel-hardening] [PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Kees Cook
On Mon, Feb 27, 2017 at 12:54 PM, Joe Perches wrote: > %pK was at least once misused at %pk in an out-of-tree module. > This lead to some security concerns. Add the ability to track > single and multiple line statements for misuses of %p. > > Signed-off-by: Joe Perches Acked-by: Kees Cook

[PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Joe Perches
%pK was at least once misused at %pk in an out-of-tree module. This lead to some security concerns. Add the ability to track single and multiple line statements for misuses of %p. Signed-off-by: Joe Perches --- Andrew, this has gone back and forth a few times. It's imperfect

[PATCH] checkpatch: Add ability to find bad uses of vsprintf %p extensions

2017-02-27 Thread Joe Perches
%pK was at least once misused at %pk in an out-of-tree module. This lead to some security concerns. Add the ability to track single and multiple line statements for misuses of %p. Signed-off-by: Joe Perches --- Andrew, this has gone back and forth a few times. It's imperfect as a patch