Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Kees Cook
On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook wrote: > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Stephen Kitt wrote: > > > On Fri, 28 Jun 2019 17:25:48 +0530, Nitin Gote > > > wrote: > > > > 1. Deprecate strcpy() in favor of strsc

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Joe Perches
On Mon, 2019-07-22 at 10:50 -0700, Kees Cook wrote: > On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook wrote: > > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Stephen Kitt wrote: > > > > On Fri, 28 Jun 2019 17:25:48 +0530, Nitin Gote >

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Stephen Kitt
On Mon, 22 Jul 2019 10:59:00 -0700, Joe Perches wrote: > On Mon, 2019-07-22 at 10:50 -0700, Kees Cook wrote: > > On Sat, Jul 06, 2019 at 02:42:04PM +0200, Stephen Kitt wrote: > > > On Tue, 2 Jul 2019 10:25:04 -0700, Kees Cook > > > wrote: > > > > On Sat, Jun 29, 2019 at 06:15:37PM +0200, Step

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Joe Perches
On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > How about you submit your current patch set, and I follow up with the above > adapted to stracpy? OK, I will shortly after I figure out how to add kernel-doc for stracpy/stracpy_pad to lib/string.c. It doesn't seem appropriate to add the ke

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Jonathan Corbet
On Mon, 22 Jul 2019 14:50:09 -0700 Joe Perches wrote: > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > > How about you submit your current patch set, and I follow up with the above > > adapted to stracpy? > > OK, I will shortly after I figure out how to add kernel-doc > for stracpy/s

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Joe Perches
On Mon, 2019-07-22 at 15:57 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 14:50:09 -0700 > Joe Perches wrote: > > > On Mon, 2019-07-22 at 23:01 +0200, Stephen Kitt wrote: > > > How about you submit your current patch set, and I follow up with the > > > above > > > adapted to stracpy? > >

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Jonathan Corbet
On Mon, 22 Jul 2019 15:24:33 -0700 Joe Perches wrote: > > If the functions themselves are fully defined in the .h file, I'd just add > > the kerneldoc there as well. That's how it's usually done, and you want > > to keep the documentation and the prototypes together. > > In this case, it's a

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-22 Thread Joe Perches
On Mon, 2019-07-22 at 16:28 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 15:24:33 -0700 > Joe Perches wrote: > > > > If the functions themselves are fully defined in the .h file, I'd just add > > > the kerneldoc there as well. That's how it's usually done, and you want > > > to keep the d

Re: [PATCH] checkpatch: Added warnings in favor of strscpy().

2019-07-24 Thread Joe Perches
On Mon, 2019-07-22 at 16:28 -0600, Jonathan Corbet wrote: > On Mon, 22 Jul 2019 15:24:33 -0700 > Joe Perches wrote: > > > > If the functions themselves are fully defined in the .h file, I'd just add > > > the kerneldoc there as well. That's how it's usually done, and you want > > > to keep the d

Re: [RFC PATCH] string.h: Add stracpy/stracpy_pad (was: Re: [PATCH] checkpatch: Added warnings in favor of strscpy().)

2019-07-22 Thread Kees Cook
On Thu, Jul 04, 2019 at 05:15:57PM -0700, Joe Perches wrote: > On Thu, 2019-07-04 at 13:46 -0700, Joe Perches wrote: > > On Thu, 2019-07-04 at 11:24 +0530, Nitin Gote wrote: > > > Added warnings in checkpatch.pl script to : > > > > > > 1. Deprecate strcpy() in favor of strscpy(). > > > 2. Deprecat

Re: [RFC PATCH] string.h: Add stracpy/stracpy_pad (was: Re: [PATCH] checkpatch: Added warnings in favor of strscpy().)

2019-07-22 Thread Matthew Wilcox
On Mon, Jul 22, 2019 at 10:58:15AM -0700, Joe Perches wrote: > On Mon, 2019-07-22 at 10:43 -0700, Joe Perches wrote: > > On Mon, 2019-07-22 at 10:33 -0700, Kees Cook wrote: > > > On Thu, Jul 04, 2019 at 05:15:57PM -0700, Joe Perches wrote: > > > > On Thu, 2019-07-04 at 13:46 -0700, Joe Perches wrot