Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Andrew Morton
On Wed, 25 Sep 2013 21:10:49 -0400 "Theodore Ts'o" wrote: > On Wed, Sep 25, 2013 at 01:03:52PM -0700, Andrew Morton wrote: > > > > Nobody uses --strict. Discussion is silly. > > If "nobody" uses it, why is it there? > Nobody understands hyperbole. -- To unsubscribe from this list: send the l

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Theodore Ts'o
On Wed, Sep 25, 2013 at 01:03:52PM -0700, Andrew Morton wrote: > > Nobody uses --strict. Discussion is silly. If "nobody" uses it, why is it there? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Joe Perches
On Wed, 2013-09-25 at 21:11 +0100, Al Viro wrote: > On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote: > > It's pretty obvious from fs/binfmt_misc.c that you have > > your own taste. > > > > $ scripts/checkpatch.pl -f --strict fs/binfmt_misc.c > > [...] > > total: 45 errors, 39 warnings,

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Al Viro
On Wed, Sep 25, 2013 at 01:03:52PM -0700, Andrew Morton wrote: > On Wed, 25 Sep 2013 21:54:49 +0200 Alexander Holler > wrote: > > > Am 25.09.2013 21:48, schrieb Joe Perches: > > > > > As I've said multiple times, checkpatch is a stupid > > > little tool that can be ignored by anyone with > > >

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Andrew Morton
On Wed, 25 Sep 2013 21:54:49 +0200 Alexander Holler wrote: > Am 25.09.2013 21:48, schrieb Joe Perches: > > > As I've said multiple times, checkpatch is a stupid > > little tool that can be ignored by anyone with > > different tastes. > > Just that this isn't true for ordinary innocent people p

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Al Viro
On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote: > It's pretty obvious from fs/binfmt_misc.c that you have > your own taste. > > $ scripts/checkpatch.pl -f --strict fs/binfmt_misc.c > [...] > total: 45 errors, 39 warnings, 10 checks, 725 lines checked *snort* Most of those are whites

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Alexander Holler
Am 25.09.2013 21:48, schrieb Joe Perches: > As I've said multiple times, checkpatch is a stupid > little tool that can be ignored by anyone with > different tastes. Just that this isn't true for ordinary innocent people posting patches. Their patches, if not passed by checkpatch.pl, usally get a

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Joe Perches
On Wed, 2013-09-25 at 15:30 -0400, Theodore Ts'o wrote: > On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote: > > > > > * labels a-la Enomem, etc. I've been using those and I will > > > keep doing so, checkpatch.pl and its users be damned. > > > > Good on you. > > I'm with Al. This

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Theodore Ts'o
On Wed, Sep 25, 2013 at 12:22:00PM -0700, Joe Perches wrote: > > > * labels a-la Enomem, etc. I've been using those and I will > > keep doing so, checkpatch.pl and its users be damned. > > Good on you. I'm with Al. This is just silly to add to checkpatch. > Fine by me. Don't use checkpat

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Joe Perches
On Wed, 2013-09-25 at 17:19 +0100, Al Viro wrote: > On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote: > > I think Propercase should be discouraged. > > ie: Qdisc et al. > > Excuse me, but "Joe happens to think that something should be discouraged" > is not a problem. "Joe uses checkpat

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Alexander Holler
Am 25.09.2013 18:19, schrieb Al Viro: On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote: We disagree. Obviously. I think Propercase should be discouraged. ie: Qdisc et al. Excuse me, but "Joe happens to think that something should be discouraged" is not a problem. "Joe uses che

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Al Viro
On Wed, Sep 25, 2013 at 08:35:44AM -0700, Joe Perches wrote: > We disagree. Obviously. > I think Propercase should be discouraged. > ie: Qdisc et al. Excuse me, but "Joe happens to think that something should be discouraged" is not a problem. "Joe uses checkpatch.pl as force multiplier, recrui

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Joe Perches
On Wed, 2013-09-25 at 16:24 +0100, Al Viro wrote: > On Tue, Sep 24, 2013 at 11:38:54AM -0700, Joe Perches wrote: > > Checkpatch doesn't currently find CamelCase definitions > > of structs, unions or enums. > > > > Add that ability. > > Fix your regex. As it is, it catches the things that are not

Re: [PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-25 Thread Al Viro
On Tue, Sep 24, 2013 at 11:38:54AM -0700, Joe Perches wrote: > Checkpatch doesn't currently find CamelCase definitions > of structs, unions or enums. > > Add that ability. Fix your regex. As it is, it catches the things that are not camelcase by any stretch of definition - [A-Z][a-z]+ will get c

[PATCH] checkpatch: Find CamelCase definitions of struct/union/enum

2013-09-24 Thread Joe Perches
Checkpatch doesn't currently find CamelCase definitions of structs, unions or enums. Add that ability. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c03e427..3d517