[PATCH] checkpatch: Improve warning message for "needless if" case

2014-10-21 Thread Fabio Estevam
Break the sentence so that it looks better: WARNING: debugfs_remove(NULL) is safe. This check is probably not required Signed-off-by: Fabio Estevam --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

Re: [PATCH] checkpatch: Improve warning message for "needless if" case

2014-10-21 Thread Joe Perches
On Tue, 2014-10-21 at 14:44 -0200, Fabio Estevam wrote: > On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches wrote: > > > > > Mixing sentences with and without periods is jarring. > > I'd prefer a comma or a dash. > > Or what about? > > "is safe and this check is probably not required" That'd be

Re: [PATCH] checkpatch: Improve warning message for "needless if" case

2014-10-21 Thread Fabio Estevam
On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches wrote: > > Mixing sentences with and without periods is jarring. > I'd prefer a comma or a dash. Or what about? "is safe and this check is probably not required" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] checkpatch: Improve warning message for "needless if" case

2014-10-21 Thread Joe Perches
On Tue, 2014-10-21 at 12:33 -0200, Fabio Estevam wrote: > Break the sentence so that it looks better: > > WARNING: debugfs_remove(NULL) is safe. This check is probably not required [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -4446,7 +4446,7 @@ sub process { >

Re: [PATCH] checkpatch: Improve warning message for needless if case

2014-10-21 Thread Joe Perches
On Tue, 2014-10-21 at 12:33 -0200, Fabio Estevam wrote: Break the sentence so that it looks better: WARNING: debugfs_remove(NULL) is safe. This check is probably not required [] diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] @@ -4446,7 +4446,7 @@ sub process {

Re: [PATCH] checkpatch: Improve warning message for needless if case

2014-10-21 Thread Fabio Estevam
On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches j...@perches.com wrote: Mixing sentences with and without periods is jarring. I'd prefer a comma or a dash. Or what about? is safe and this check is probably not required -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH] checkpatch: Improve warning message for needless if case

2014-10-21 Thread Joe Perches
On Tue, 2014-10-21 at 14:44 -0200, Fabio Estevam wrote: On Tue, Oct 21, 2014 at 2:40 PM, Joe Perches j...@perches.com wrote: Mixing sentences with and without periods is jarring. I'd prefer a comma or a dash. Or what about? is safe and this check is probably not required That'd be

[PATCH] checkpatch: Improve warning message for needless if case

2014-10-21 Thread Fabio Estevam
Break the sentence so that it looks better: WARNING: debugfs_remove(NULL) is safe. This check is probably not required Signed-off-by: Fabio Estevam fabio.este...@freescale.com --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl