Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Jakub Kicinski
On Sat, 2 May 2020 00:36:48 + Keller, Jacob E wrote: > > The ones I specified previously use: > > > > NL_SET_ERR_MSG_MOD(extack, "message\n"); > > > > where all the others uses are: > > > > NL_SET_ERR_MSG_MOD(extack, "message"); > > > > without the \n termination of the message. >

RE: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Keller, Jacob E
> -Original Message- > From: Joe Perches > Sent: Friday, May 01, 2020 5:30 PM > To: Keller, Jacob E ; linux-kernel@vger.kernel.org > Cc: Jakub Kicinski ; Andy Whitcroft > Subject: Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column > exceptions > > On Fri

Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Joe Perches
On Fri, 2020-05-01 at 17:19 -0700, Jacob Keller wrote: > > On 5/1/2020 4:42 PM, Joe Perches wrote: > > On Fri, 2020-05-01 at 16:11 -0700, Jacob Keller wrote: > > > NL_SET_ERR_MSG and NL_SET_ERR_MSG_MOD are used to report extended error > > > responses about failure of a netlink command. These

Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Jacob Keller
On 5/1/2020 4:42 PM, Joe Perches wrote: > On Fri, 2020-05-01 at 16:11 -0700, Jacob Keller wrote: >> NL_SET_ERR_MSG and NL_SET_ERR_MSG_MOD are used to report extended error >> responses about failure of a netlink command. These strings often end up >> going over the 80-column limit. Just like

Re: [PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Joe Perches
On Fri, 2020-05-01 at 16:11 -0700, Jacob Keller wrote: > NL_SET_ERR_MSG and NL_SET_ERR_MSG_MOD are used to report extended error > responses about failure of a netlink command. These strings often end up > going over the 80-column limit. Just like logging messages, it is > preferred to leave the

[PATCH] checkpatch: add NL_SET_ERR_MSG to 80 column exceptions

2020-05-01 Thread Jacob Keller
NL_SET_ERR_MSG and NL_SET_ERR_MSG_MOD are used to report extended error responses about failure of a netlink command. These strings often end up going over the 80-column limit. Just like logging messages, it is preferred to leave the message all on a single line. Add these to the exception list