Re: [PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-02-04 Thread Timur Tabi
Andy Whitcroft wrote: It truly is not clear what "type" of thing an __asm__ is these days. Cirtainly it seems we can use it as an attribute of a type: register unsigned long __r16 __asm__("$16") = rtc_access->function; and yet also in its more traditional form: __asm__("

Re: [PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-02-04 Thread Andy Whitcroft
On Tue, Jan 29, 2008 at 05:17:28PM -0600, Timur Tabi wrote: > checkpatch.pl thinks that __asm__ is a function name, so it complains about > a space between the function name and a parenthesis when it sees > "__asm__ ("mov ax,bx")". > > This change will also encourage developers to use '__asm__'

Re: [PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-02-04 Thread Andy Whitcroft
On Tue, Jan 29, 2008 at 05:17:28PM -0600, Timur Tabi wrote: checkpatch.pl thinks that __asm__ is a function name, so it complains about a space between the function name and a parenthesis when it sees __asm__ (mov ax,bx). This change will also encourage developers to use '__asm__' instead of

Re: [PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-02-04 Thread Timur Tabi
Andy Whitcroft wrote: It truly is not clear what type of thing an __asm__ is these days. Cirtainly it seems we can use it as an attribute of a type: register unsigned long __r16 __asm__($16) = rtc_access-function; and yet also in its more traditional form: __asm__( call

[PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-01-29 Thread Timur Tabi
checkpatch.pl thinks that __asm__ is a function name, so it complains about a space between the function name and a parenthesis when it sees "__asm__ ("mov ax,bx")". This change will also encourage developers to use '__asm__' instead of 'asm'. Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> ---

[PATCH] checkpatch: add __asm__ to function-space-paren exception list

2008-01-29 Thread Timur Tabi
checkpatch.pl thinks that __asm__ is a function name, so it complains about a space between the function name and a parenthesis when it sees __asm__ (mov ax,bx). This change will also encourage developers to use '__asm__' instead of 'asm'. Signed-off-by: Timur Tabi [EMAIL PROTECTED] ---