Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-17 Thread Dirk Gouders
Joe Perches writes: > On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: >> Because the kbuild function if_changed writes the command line to a >> .cmd file for later tests, multiple calls of that function within a >> target would result in overwrites of previous values and effectively >>

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-17 Thread Dirk Gouders
Joe Perches writes: > On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: >> Because the kbuild function if_changed writes the command line to a >> .cmd file for later tests, multiple calls of that function within a >> target would result in overwrites of previous values and effectively >>

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Joe Perches
On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: > Because the kbuild function if_changed writes the command line to a > .cmd file for later tests, multiple calls of that function within a > target would result in overwrites of previous values and effectively > render the command line test

Re: [PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Joe Perches
On Mon, 2018-07-16 at 14:39 +0200, Dirk Gouders wrote: > Because the kbuild function if_changed writes the command line to a > .cmd file for later tests, multiple calls of that function within a > target would result in overwrites of previous values and effectively > render the command line test

[PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Dirk Gouders
Because the kbuild function if_changed writes the command line to a .cmd file for later tests, multiple calls of that function within a target would result in overwrites of previous values and effectively render the command line test meaningless, resulting in flip-flop behaviour. Produce an error

[PATCH] checkpatch: if_changed: check for multiple calls in targets

2018-07-16 Thread Dirk Gouders
Because the kbuild function if_changed writes the command line to a .cmd file for later tests, multiple calls of that function within a target would result in overwrites of previous values and effectively render the command line test meaningless, resulting in flip-flop behaviour. Produce an error