Re: [PATCH] cifs: fix page reference leak with readv/writev

2019-04-20 Thread Steve French
updated patch in cifs-2.6.git for-next On Thu, Apr 18, 2019 at 4:45 PM Pavel Shilovsky wrote: > > чт, 18 апр. 2019 г. в 14:12, Jerome Glisse : > > > > On Wed, Apr 10, 2019 at 09:47:01PM -0500, Steve French wrote: > > > How was this discovered? Does it address a reported user problem? > > > > I ha

Re: [PATCH] cifs: fix page reference leak with readv/writev

2019-04-18 Thread Pavel Shilovsky
чт, 18 апр. 2019 г. в 14:12, Jerome Glisse : > > On Wed, Apr 10, 2019 at 09:47:01PM -0500, Steve French wrote: > > How was this discovered? Does it address a reported user problem? > > I have spotted it while tracking down how page reference are taken > for bio and how they are release. In the curr

Re: [PATCH] cifs: fix page reference leak with readv/writev

2019-04-18 Thread Jerome Glisse
On Wed, Apr 10, 2019 at 09:47:01PM -0500, Steve French wrote: > How was this discovered? Does it address a reported user problem? I have spotted it while tracking down how page reference are taken for bio and how they are release. In the current code, once the page are GUPed they are never release

Re: [PATCH] cifs: fix page reference leak with readv/writev

2019-04-10 Thread Steve French
How was this discovered? Does it address a reported user problem? On Wed, Apr 10, 2019 at 2:38 PM wrote: > > From: Jérôme Glisse > > CIFS can leak pages reference gotten through GUP (get_user_pages*() > through iov_iter_get_pages()). This happen if cifs_send_async_read() > or cifs_write_from_ite

[PATCH] cifs: fix page reference leak with readv/writev

2019-04-10 Thread jglisse
From: Jérôme Glisse CIFS can leak pages reference gotten through GUP (get_user_pages*() through iov_iter_get_pages()). This happen if cifs_send_async_read() or cifs_write_from_iter() calls fail from within __cifs_readv() and __cifs_writev() respectively. This patch move page unreference to cifs_a