Re: [PATCH] cifs: remove useless cargo-cult checks

2007-03-07 Thread Steve French
Christoph Hellwig <[EMAIL PROTECTED]> wrote on 03/07/2007 04:17:46 PM: > On Wed, Mar 07, 2007 at 12:51:04PM -0600, Steven French wrote: > > Is there an easy way to mirror particular patches going into the > > cifs-2.6.git tree (which is pulled into mm) to lkml? > > Maybe some git expert can comm

Re: [PATCH] cifs: remove useless cargo-cult checks

2007-03-07 Thread Randy Dunlap
On Wed, 7 Mar 2007 23:17:46 +0100 Christoph Hellwig wrote: > On Wed, Mar 07, 2007 at 12:51:04PM -0600, Steven French wrote: > > > file->f_path.dentry or file->f_path.dentry.d_inode can't be NULL > > > > OK - I don't really mind removing these checks - and I agree that I there > > is not an obviou

Re: [PATCH] cifs: remove useless cargo-cult checks

2007-03-07 Thread Christoph Hellwig
On Wed, Mar 07, 2007 at 12:51:04PM -0600, Steven French wrote: > > file->f_path.dentry or file->f_path.dentry.d_inode can't be NULL > > OK - I don't really mind removing these checks - and I agree that I there > is not an obvious way that they can be null, yet we had a case in which > file->f_dent

[PATCH] cifs: remove useless cargo-cult checks

2007-03-07 Thread Christoph Hellwig
file->f_path.dentry or file->f_path.dentry.d_inode can't be NULL since at least ten years, similar for all but very few arguments passed in from the VFS. Btw, it would be nice if all CIFS updates could be Cc'ed to lkml to fix things like this or the horrible codingstyle before it hits the tree.