Re: [PATCH] Clean up mach_reboot_fixups

2007-03-28 Thread Andi Kleen
On Wednesday 28 March 2007 22:11, Jeremy Fitzhardinge wrote: > Two cleanups: > - reboot_fixups.h is entirely i386-dependent, so put it in asm-i386 > - use a weak version rather than ifdeffery > > [ Andi - the machine_ops probably depends on this, but only in a minor > context-clash way. ] Sor

[PATCH] Clean up mach_reboot_fixups

2007-03-28 Thread Jeremy Fitzhardinge
Two cleanups: - reboot_fixups.h is entirely i386-dependent, so put it in asm-i386 - use a weak version rather than ifdeffery [ Andi - the machine_ops probably depends on this, but only in a minor context-clash way. ] Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jaya Kumar <[EMAI

Re: Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups)

2007-03-19 Thread Eric W. Biederman
Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: > Andi Kleen wrote: >> On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote: >> >>> The reboot_fixups stuff seems to be a bit of a mess, specifically the >>> header is in linux/ when its a purely i386-specific piece of code. I'm >>> not su

Geode cs5530a magic (Was: Re: [PATCH] clean up mach_reboot_fixups)

2007-03-14 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote: > >> The reboot_fixups stuff seems to be a bit of a mess, specifically the >> header is in linux/ when its a purely i386-specific piece of code. I'm >> not sure why it has its config option; its only currently need

Re: [PATCH] clean up mach_reboot_fixups

2007-03-14 Thread Andi Kleen
On Wednesday 14 March 2007 23:24, Jeremy Fitzhardinge wrote: > The reboot_fixups stuff seems to be a bit of a mess, specifically the > header is in linux/ when its a purely i386-specific piece of code. I'm > not sure why it has its config option; its only currently needed for > "geode-gx1/cs5530a"

[PATCH] clean up mach_reboot_fixups

2007-03-14 Thread Jeremy Fitzhardinge
The reboot_fixups stuff seems to be a bit of a mess, specifically the header is in linux/ when its a purely i386-specific piece of code. I'm not sure why it has its config option; its only currently needed for "geode-gx1/cs5530a", so perhaps whatever config option controls that hardware should ena