RE: [PATCH] clk: Add functions to get optional clocks

2018-07-27 Thread Stephen Boyd
Quoting Phil Edworthy (2018-07-27 08:38:12) > On 25 July 2018 23:37, Stephen Boyd wrote: > > Short answer is they don't. I'd still prefer we have this API though. > > > > Can you rework this patch to be a little more invasive into the > > clk_get() path, perhaps by reworking __of_clk_get_by_name()

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-27 Thread Phil Edworthy
Hi Stephen, On 25 July 2018 23:37, Stephen Boyd wrote: > Quoting Phil Edworthy (2018-07-18 06:56:26) > > On 18 July 2018 14:19, Geert Uytterhoeven wrote: > > > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > > > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: >

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-25 Thread Stephen Boyd
Quoting Phil Edworthy (2018-07-18 06:56:26) > Hi Russell, > > On 18 July 2018 14:19, Geert Uytterhoeven wrote: > > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > > > > Behaves the same as (devm_)clk_get except

Re: [PATCH] clk: Add functions to get optional clocks

2018-07-18 Thread kbuild test robot
Hi Phil, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v4.18-rc5 next-20180718] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/l

RE: [PATCH] clk: Add functions to get optional clocks

2018-07-18 Thread Phil Edworthy
Hi Russell, On 18 July 2018 14:19, Geert Uytterhoeven wrote: > On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > > > Behaves the same as (devm_)clk_get except where there is no clock > > > producer. In this case, i

Re: [PATCH] clk: Add functions to get optional clocks

2018-07-18 Thread Geert Uytterhoeven
Hi Russell, On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote: > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > > Behaves the same as (devm_)clk_get except where there is no clock > > producer. In this case, instead of returning -ENOENT, the function > > returns NUL

Re: [PATCH] clk: Add functions to get optional clocks

2018-07-18 Thread Russell King - ARM Linux
On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote: > Behaves the same as (devm_)clk_get except where there is no clock > producer. In this case, instead of returning -ENOENT, the function > returns NULL. This makes error checking simpler and allows > clk_prepare_enable, etc to be called

[PATCH] clk: Add functions to get optional clocks

2018-07-18 Thread Phil Edworthy
Behaves the same as (devm_)clk_get except where there is no clock producer. In this case, instead of returning -ENOENT, the function returns NULL. This makes error checking simpler and allows clk_prepare_enable, etc to be called on the returned reference without additional checks. Signed-off-by: P