Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-10 Thread Rob Herring
On Wed, Feb 10, 2021 at 10:00:14AM +0100, Greg Kroah-Hartman wrote: > On Wed, Feb 10, 2021 at 09:51:14AM +0100, Geert Uytterhoeven wrote: > > Hi Saravana, > > > > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan > > wrote: > > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > > > Quoting

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-10 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Feb 10, 2021 at 9:57 AM Saravana Kannan wrote: > On Wed, Feb 10, 2021 at 12:51 AM Geert Uytterhoeven > wrote: > > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan > > wrote: > > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > > > Quoting tudor.amba...@microchip.co

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-10 Thread Saravana Kannan
On Wed, Feb 10, 2021 at 12:51 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan wrote: > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > > Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > > > > Do you plan to take this patch for

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-10 Thread Greg Kroah-Hartman
On Wed, Feb 10, 2021 at 09:51:14AM +0100, Geert Uytterhoeven wrote: > Hi Saravana, > > On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan wrote: > > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > > Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > > > > Do you plan to take this pa

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-10 Thread Geert Uytterhoeven
Hi Saravana, On Wed, Feb 10, 2021 at 1:57 AM Saravana Kannan wrote: > On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > > > Do you plan to take this patch for v5.12? > > > If fw_devlink will remain set to ON for v5.12, some of our

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-09 Thread Saravana Kannan
On Tue, Feb 9, 2021 at 4:54 PM Stephen Boyd wrote: > > Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > > Hi, Michael, Stephen, > > > > Do you plan to take this patch for v5.12? > > If fw_devlink will remain set to ON for v5.12, some of our boards will > > no longer boot without this pa

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-09 Thread Stephen Boyd
Quoting Tudor Ambarus (2021-02-03 07:43:32) > These are all "early clocks" that require initialization just at > of_clk_init() time. Use CLK_OF_DECLARE() to declare them. > > This also fixes a problem that was spotted when fw_devlink was > set to 'on' by default: the boards failed to boot. The rea

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-09 Thread Stephen Boyd
Quoting tudor.amba...@microchip.com (2021-02-08 01:49:45) > Hi, Michael, Stephen, > > Do you plan to take this patch for v5.12? > If fw_devlink will remain set to ON for v5.12, some of our boards will > no longer boot without this patch. Is fw_devlink defaulted to on for v5.12?

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-08 Thread Tudor.Ambarus
Hi, Michael, Stephen, Do you plan to take this patch for v5.12? If fw_devlink will remain set to ON for v5.12, some of our boards will no longer boot without this patch. Cheers, ta On 2/3/21 5:43 PM, Tudor Ambarus wrote: > These are all "early clocks" that require initialization just at > of_clk

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-04 Thread Nicolas Ferre
On 03/02/2021 at 16:43, Tudor Ambarus wrote: These are all "early clocks" that require initialization just at of_clk_init() time. Use CLK_OF_DECLARE() to declare them. This also fixes a problem that was spotted when fw_devlink was set to 'on' by default: the boards failed to boot. The reason is

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-04 Thread Eugen.Hristev
On 03.02.2021 20:15, Saravana Kannan wrote: > On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus > wrote: >> >> These are all "early clocks" that require initialization just at >> of_clk_init() time. Use CLK_OF_DECLARE() to declare them. >> >> This also fixes a problem that was spotted when fw_devlink w

Re: [PATCH] clk: at91: Fix the declaration of the clocks

2021-02-03 Thread Saravana Kannan
On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus wrote: > > These are all "early clocks" that require initialization just at > of_clk_init() time. Use CLK_OF_DECLARE() to declare them. > > This also fixes a problem that was spotted when fw_devlink was > set to 'on' by default: the boards failed to boo

[PATCH] clk: at91: Fix the declaration of the clocks

2021-02-03 Thread Tudor Ambarus
These are all "early clocks" that require initialization just at of_clk_init() time. Use CLK_OF_DECLARE() to declare them. This also fixes a problem that was spotted when fw_devlink was set to 'on' by default: the boards failed to boot. The reason is that CLK_OF_DECLARE_DRIVER() clears the OF_POPU