Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-10 Thread Tudor.Ambarus
Hi, Saravana, On 2/9/21 9:06 PM, Saravana Kannan wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Tue, Feb 9, 2021 at 7:21 AM wrote: >> >> Hi, Saravana, >> >> On 2/9/21 11:11 AM, Saravana Kannan wrote: >>> EXTERNAL EMAIL: Do not click

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-09 Thread Saravana Kannan
On Tue, Feb 9, 2021 at 7:21 AM wrote: > > Hi, Saravana, > > On 2/9/21 11:11 AM, Saravana Kannan wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > On Mon, Feb 8, 2021 at 11:55 PM Stephen Boyd wrote: > >> > >> Quoting Saravana Kannan

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-09 Thread Tudor.Ambarus
Hi, Saravana, On 2/9/21 11:11 AM, Saravana Kannan wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, Feb 8, 2021 at 11:55 PM Stephen Boyd wrote: >> >> Quoting Saravana Kannan (2021-01-28 09:01:41) >>> On Thu, Jan 28, 2021 at 2:45

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-09 Thread Tudor.Ambarus
Hi, Stephen, On 2/9/21 9:55 AM, Stephen Boyd wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Quoting Saravana Kannan (2021-01-28 09:01:41) >> On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus >> wrote: >>> >>> The sama5d2 requires the clock

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-09 Thread Saravana Kannan
On Mon, Feb 8, 2021 at 11:55 PM Stephen Boyd wrote: > > Quoting Saravana Kannan (2021-01-28 09:01:41) > > On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus > > wrote: > > > > > > The sama5d2 requires the clock provider initialized before timers. > > > We can't use a platform driver for the

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-08 Thread Stephen Boyd
Quoting Saravana Kannan (2021-01-28 09:01:41) > On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus > wrote: > > > > The sama5d2 requires the clock provider initialized before timers. > > We can't use a platform driver for the sama5d2-pmc driver, as the > > platform_bus_init() is called later on, after

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-01 Thread Saravana Kannan
On Mon, Feb 1, 2021 at 2:54 AM Geert Uytterhoeven wrote: > > Hi Saravana, > > On Thu, Jan 28, 2021 at 6:08 PM Saravana Kannan wrote: > > I already accounted for early clocks like this when I designed > > fw_devlink. Each driver shouldn't need to set OF_POPULATED. > > drivers/clk/clk.c already

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-02-01 Thread Geert Uytterhoeven
Hi Saravana, On Thu, Jan 28, 2021 at 6:08 PM Saravana Kannan wrote: > I already accounted for early clocks like this when I designed > fw_devlink. Each driver shouldn't need to set OF_POPULATED. > drivers/clk/clk.c already does this for you. > > I think the problem is that your driver is using >

Re: [PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-01-28 Thread Saravana Kannan
On Thu, Jan 28, 2021 at 2:45 AM Tudor Ambarus wrote: > > The sama5d2 requires the clock provider initialized before timers. > We can't use a platform driver for the sama5d2-pmc driver, as the > platform_bus_init() is called later on, after time_init(). > > As fw_devlink considers only devices, it

[PATCH] clk: at91: sama5d2: Mark device OF_POPULATED after setup

2021-01-28 Thread Tudor Ambarus
The sama5d2 requires the clock provider initialized before timers. We can't use a platform driver for the sama5d2-pmc driver, as the platform_bus_init() is called later on, after time_init(). As fw_devlink considers only devices, it does not know that the pmc is ready. Hence probing of devices