Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-27 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-07 09:24:10) > Commit c686078 ("clk: divider: Add round to closest divider") introduced > a helper function to check whether given divisor is the best one instead > of direct check. However due to int type used instead of unsigned long > for passing calculated rates to

[FIX] [CRITICAL] Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-24 Thread Tomasz Figa
Mike, On 15.05.2014 18:51, Tomasz Figa wrote: > Hi Mike, > > On 07.05.2014 18:24, Tomasz Figa wrote: >> Commit c686078 ("clk: divider: Add round to closest divider") introduced >> a helper function to check whether given divisor is the best one instead >> of direct check. However due to int type

Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-15 Thread Tomasz Figa
Hi Mike, On 07.05.2014 18:24, Tomasz Figa wrote: > Commit c686078 ("clk: divider: Add round to closest divider") introduced > a helper function to check whether given divisor is the best one instead > of direct check. However due to int type used instead of unsigned long > for passing calculated r

Re: [PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-07 Thread Maxime Coquelin
Hi Tomasz, On 05/07/2014 06:24 PM, Tomasz Figa wrote: Commit c686078 ("clk: divider: Add round to closest divider") introduced a helper function to check whether given divisor is the best one instead of direct check. However due to int type used instead of unsigned long for passing calculated ra

[PATCH] clk: divider: Fix overflow in clk_divider_bestdiv

2014-05-07 Thread Tomasz Figa
Commit c686078 ("clk: divider: Add round to closest divider") introduced a helper function to check whether given divisor is the best one instead of direct check. However due to int type used instead of unsigned long for passing calculated rates to this function in certain cases an overflow could o