Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-17 Thread Rajendra Nayak
On Tuesday 17 July 2012 07:16 PM, Rob Herring wrote: So how is this expected to work on platforms (like OMAP) which have > CONFIG_OF enabled but not CONFIG_COMMON_CLK? > As I mentioned in my other reply, this really belongs with Shawn's patch that changes the return value checking from NULL to

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-17 Thread Rob Herring
On 07/17/2012 08:19 AM, Rajendra Nayak wrote: > Rob, Mike, > > On Tuesday 17 July 2012 07:38 AM, Rob Herring wrote: >> On 07/16/2012 07:12 PM, Mike Turquette wrote: >>> On 20120716-16:46, Rob Herring wrote: From: Rob Herring With commit 766e6a4ec602d0c107 (clk: add DT clock binding

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-17 Thread Rajendra Nayak
On Tuesday 17 July 2012 06:49 PM, Rajendra Nayak wrote: struct clk *clk_get(struct device *dev, const char *con_id) { const char *dev_id = dev ? dev_name(dev) : NULL; struct clk *clk; if (dev) { > Any reason why this isn't if (dev->of_node) { > Or r

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-17 Thread Rajendra Nayak
Rob, Mike, On Tuesday 17 July 2012 07:38 AM, Rob Herring wrote: On 07/16/2012 07:12 PM, Mike Turquette wrote: On 20120716-16:46, Rob Herring wrote: From: Rob Herring With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), compiling with OF&& !COMMON_CLK is broken. Hi Rob, Tha

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-16 Thread Prashant Gaikwad
On Tuesday 17 July 2012 03:16 AM, Rob Herring wrote: From: Rob Herring With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), compiling with OF&& !COMMON_CLK is broken. Thanks Rob!! This patch fixed the build failure for Tegra. Reported-by: Alexandre Pereira da Silva Reported-

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-16 Thread Rob Herring
On 07/16/2012 07:12 PM, Mike Turquette wrote: > On 20120716-16:46, Rob Herring wrote: >> From: Rob Herring >> >> With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), >> compiling with OF && !COMMON_CLK is broken. >> > > Hi Rob, > > Thanks for sending this quickly. > > >> @@ -313

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-16 Thread Alexandre Pereira da Silva
On Mon, Jul 16, 2012 at 6:46 PM, Rob Herring wrote: > From: Rob Herring > > With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), > compiling with OF && !COMMON_CLK is broken. Thanks, Rob. This fixed the issue for me, but Mike's comments applies. > Reported-by: Alexandre Pereira

Re: [PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-16 Thread Mike Turquette
On 20120716-16:46, Rob Herring wrote: > From: Rob Herring > > With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), > compiling with OF && !COMMON_CLK is broken. > Hi Rob, Thanks for sending this quickly. > @@ -313,19 +314,19 @@ int clk_add_alias(const char *alias, const char

[PATCH] clk: fix compile for OF && !COMMON_CLK

2012-07-16 Thread Rob Herring
From: Rob Herring With commit 766e6a4ec602d0c107 (clk: add DT clock binding support), compiling with OF && !COMMON_CLK is broken. Reported-by: Alexandre Pereira da Silva Reported-by: Prashant Gaikwad Signed-off-by: Rob Herring --- drivers/clk/clkdev.c |2 +- include/linux/clk.h |7 +