Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-10-02 Thread Tero Kristo
On 09/30/2014 10:03 PM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-30 01:48:49) On 09/30/2014 10:07 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM,

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-10-02 Thread Tero Kristo
On 09/30/2014 10:03 PM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-30 01:48:49) On 09/30/2014 10:07 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM,

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Mike Turquette
Quoting Tero Kristo (2014-09-30 01:48:49) > On 09/30/2014 10:07 AM, Mike Turquette wrote: > > Quoting Tero Kristo (2014-09-29 01:09:24) > >> On 09/27/2014 02:24 AM, Mike Turquette wrote: > >>> Quoting Tero Kristo (2014-09-26 00:18:55) > On 09/26/2014 04:35 AM, Stephen Boyd wrote: > > On

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Tero Kristo
On 09/30/2014 10:07 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Mike Turquette
Quoting Tero Kristo (2014-09-29 01:09:24) > On 09/27/2014 02:24 AM, Mike Turquette wrote: > > Quoting Tero Kristo (2014-09-26 00:18:55) > >> On 09/26/2014 04:35 AM, Stephen Boyd wrote: > >>> On 09/23/14 06:38, Tero Kristo wrote: > On 09/22/2014 10:18 PM, Stephen Boyd wrote: > > On 08/21,

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Mike Turquette
Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote:

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Tero Kristo
On 09/30/2014 10:07 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-30 Thread Mike Turquette
Quoting Tero Kristo (2014-09-30 01:48:49) On 09/30/2014 10:07 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-29 01:09:24) On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-29 Thread Tero Kristo
On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-29 Thread Tero Kristo
On 09/27/2014 02:24 AM, Mike Turquette wrote: Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-26 Thread Mike Turquette
Quoting Tero Kristo (2014-09-26 00:18:55) > On 09/26/2014 04:35 AM, Stephen Boyd wrote: > > On 09/23/14 06:38, Tero Kristo wrote: > >> On 09/22/2014 10:18 PM, Stephen Boyd wrote: > >>> On 08/21, Tero Kristo wrote: > /* Skip children who will be reparented to another clock */ >

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-26 Thread Tero Kristo
On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be reparented to another clock */ if (child->new_parent && child->new_parent != clk)

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-26 Thread Tero Kristo
On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be reparented to another clock */ if (child-new_parent child-new_parent != clk)

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-26 Thread Mike Turquette
Quoting Tero Kristo (2014-09-26 00:18:55) On 09/26/2014 04:35 AM, Stephen Boyd wrote: On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be reparented to another clock */ if

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-25 Thread Stephen Boyd
On 09/23/14 06:38, Tero Kristo wrote: > On 09/22/2014 10:18 PM, Stephen Boyd wrote: >> On 08/21, Tero Kristo wrote: >>> /* Skip children who will be reparented to another clock */ >>> if (child->new_parent && child->new_parent != clk) >>> continue; >> >> Are we

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-25 Thread Stephen Boyd
On 09/23/14 06:38, Tero Kristo wrote: On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: /* Skip children who will be reparented to another clock */ if (child-new_parent child-new_parent != clk) continue; Are we not hitting the

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-23 Thread Tero Kristo
On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-23 Thread Tero Kristo
On 09/22/2014 10:18 PM, Stephen Boyd wrote: On 08/21, Tero Kristo wrote: In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-22 Thread Stephen Boyd
On 08/21, Tero Kristo wrote: > In some cases, clocks can switch their parent with clk_set_rate, for > example clk_mux can do this in some cases. Current implementation of > clk_change_rate uses un-safe list iteration on the clock children, which > will cause wrong clocks to be parsed in case any

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-22 Thread Stephen Boyd
On 08/21, Tero Kristo wrote: In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in case any of

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-17 Thread Felipe Balbi
Hi Mike, On Wed, Sep 03, 2014 at 12:22:03PM -0700, Mike Turquette wrote: > Quoting Tero Kristo (2014-08-21 06:47:45) > > In some cases, clocks can switch their parent with clk_set_rate, for > > example clk_mux can do this in some cases. Current implementation of > > clk_change_rate uses un-safe

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-17 Thread Felipe Balbi
Hi Mike, On Wed, Sep 03, 2014 at 12:22:03PM -0700, Mike Turquette wrote: Quoting Tero Kristo (2014-08-21 06:47:45) In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-03 Thread Mike Turquette
Quoting Tero Kristo (2014-08-21 06:47:45) > In some cases, clocks can switch their parent with clk_set_rate, for > example clk_mux can do this in some cases. Current implementation of > clk_change_rate uses un-safe list iteration on the clock children, which > will cause wrong clocks to be parsed

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-09-03 Thread Mike Turquette
Quoting Tero Kristo (2014-08-21 06:47:45) In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-08-21 Thread Nishanth Menon
On 16:47-20140821, Tero Kristo wrote: > In some cases, clocks can switch their parent with clk_set_rate, for > example clk_mux can do this in some cases. Current implementation of > clk_change_rate uses un-safe list iteration on the clock children, which > will cause wrong clocks to be parsed in

[PATCH] clk: prevent erronous parsing of children during rate change

2014-08-21 Thread Tero Kristo
In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in case any of the clock children change their

[PATCH] clk: prevent erronous parsing of children during rate change

2014-08-21 Thread Tero Kristo
In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in case any of the clock children change their

Re: [PATCH] clk: prevent erronous parsing of children during rate change

2014-08-21 Thread Nishanth Menon
On 16:47-20140821, Tero Kristo wrote: In some cases, clocks can switch their parent with clk_set_rate, for example clk_mux can do this in some cases. Current implementation of clk_change_rate uses un-safe list iteration on the clock children, which will cause wrong clocks to be parsed in case