Re: [PATCH] clk: qcom: gdsc: Keep RETAIN_FF bit set if gdsc is already on

2020-10-20 Thread Stephen Boyd
Quoting Stephen Boyd (2020-10-16 19:01:37) > If the GDSC is enabled out of boot but doesn't have the retain ff bit > set we will get confusing results where the registers that are powered > by the GDSC lose their contents on the first power off of the GDSC but > thereafter they retain their

Re: [PATCH] clk: qcom: gdsc: Keep RETAIN_FF bit set if gdsc is already on

2020-10-19 Thread Doug Anderson
Hi, On Fri, Oct 16, 2020 at 7:01 PM Stephen Boyd wrote: > > If the GDSC is enabled out of boot but doesn't have the retain ff bit > set we will get confusing results where the registers that are powered > by the GDSC lose their contents on the first power off of the GDSC but > thereafter they

Re: [PATCH] clk: qcom: gdsc: Keep RETAIN_FF bit set if gdsc is already on

2020-10-17 Thread Taniya Das
Reviewed-by: Taniya Das On 10/17/2020 7:31 AM, Stephen Boyd wrote: If the GDSC is enabled out of boot but doesn't have the retain ff bit set we will get confusing results where the registers that are powered by the GDSC lose their contents on the first power off of the GDSC but thereafter they

[PATCH] clk: qcom: gdsc: Keep RETAIN_FF bit set if gdsc is already on

2020-10-16 Thread Stephen Boyd
If the GDSC is enabled out of boot but doesn't have the retain ff bit set we will get confusing results where the registers that are powered by the GDSC lose their contents on the first power off of the GDSC but thereafter they retain their contents. This is because gdsc_init() fails to make sure