Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-21 Thread Kees Cook
On Thu, Feb 21, 2019 at 1:43 PM Stephen Boyd wrote: > Ok, thanks for the background. Looks like the perf tool already > introduced the #define __fallthrough that they use for this purpose. > Maybe they're hoping that it will be formalized. Yeah, GCC has an extension for it (but it's not yet part

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-21 Thread Stephen Boyd
Quoting Gustavo A. R. Silva (2019-02-11 10:15:31) > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/clk/samsung/clk-s3c2443.c: In function ‘s3c2443_common_clk_init’: >

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-21 Thread Stephen Boyd
Quoting Kees Cook (2019-02-20 14:26:06) > On Fri, Feb 15, 2019 at 4:34 PM Stephen Boyd wrote: > > Quoting Kees Cook (2019-02-12 10:57:05) > > > On Mon, Feb 11, 2019 at 11:41 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > It is just the GCC which has to be fixed not the code. You want to >

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-20 Thread Kees Cook
On Fri, Feb 15, 2019 at 4:34 PM Stephen Boyd wrote: > Quoting Kees Cook (2019-02-12 10:57:05) > > On Mon, Feb 11, 2019 at 11:41 PM Krzysztof Kozlowski > > wrote: > > > > > > It is just the GCC which has to be fixed not the code. You want to > > > adjust the code for specific version of GCC and

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-15 Thread Stephen Boyd
Quoting Kees Cook (2019-02-12 10:57:05) > On Mon, Feb 11, 2019 at 11:41 PM Krzysztof Kozlowski wrote: > > > > It is just the GCC which has to be fixed not the code. You want to > > adjust the code for specific version of GCC and what if GCC changes > > its warning? For example GCC might require

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-12 Thread Kees Cook
On Mon, Feb 11, 2019 at 11:41 PM Krzysztof Kozlowski wrote: > > On Mon, 11 Feb 2019 at 19:40, Gustavo A. R. Silva > wrote: > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > cases where we are expecting to fall through. > > > > This patch fixes the following warnings: > >

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-11 Thread Krzysztof Kozlowski
On Mon, 11 Feb 2019 at 19:40, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/clk/samsung/clk-s3c2443.c: In function ‘s3c2443_common_clk_init’: >

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-11 Thread Chanwoo Choi
Hi Gustavo, On 19. 2. 12. 오전 3:15, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/clk/samsung/clk-s3c2443.c: In function

[PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-11 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/clk/samsung/clk-s3c2443.c: In function ‘s3c2443_common_clk_init’: drivers/clk/samsung/clk-s3c2443.c:390:3: warning: this statement may