Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Stephen Boyd
On 01/12/2017 02:42 PM, Arnd Bergmann wrote: > On Thu, Jan 12, 2017 at 11:06 PM, Stephen Boyd wrote: >> Applied to clk-next. Seems I need to update my compiler to find >> these warnings. > I'm currently playing with gcc-7, which adds a lot of new warnings > (including many

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Stephen Boyd
On 01/12/2017 02:42 PM, Arnd Bergmann wrote: > On Thu, Jan 12, 2017 at 11:06 PM, Stephen Boyd wrote: >> Applied to clk-next. Seems I need to update my compiler to find >> these warnings. > I'm currently playing with gcc-7, which adds a lot of new warnings > (including many false positives). gcc-6

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Arnd Bergmann
On Thu, Jan 12, 2017 at 11:06 PM, Stephen Boyd wrote: > > Applied to clk-next. Seems I need to update my compiler to find > these warnings. I'm currently playing with gcc-7, which adds a lot of new warnings (including many false positives). gcc-6 was supposed to have better

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Arnd Bergmann
On Thu, Jan 12, 2017 at 11:06 PM, Stephen Boyd wrote: > > Applied to clk-next. Seems I need to update my compiler to find > these warnings. I'm currently playing with gcc-7, which adds a lot of new warnings (including many false positives). gcc-6 was supposed to have better warnings than 5, but

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Stephen Boyd
On 01/11, Arnd Bergmann wrote: > The failure path in the newly added function tries to free an > uninitialized pointer: > > drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': > drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in > this function

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-12 Thread Stephen Boyd
On 01/11, Arnd Bergmann wrote: > The failure path in the newly added function tries to free an > uninitialized pointer: > > drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': > drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in > this function

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-11 Thread Gabriel Fernandez
On 01/11/2017 02:40 PM, Arnd Bergmann wrote: The failure path in the newly added function tries to free an uninitialized pointer: drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in this function

Re: [PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-11 Thread Gabriel Fernandez
On 01/11/2017 02:40 PM, Arnd Bergmann wrote: The failure path in the newly added function tries to free an uninitialized pointer: drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in this function

[PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-11 Thread Arnd Bergmann
The failure path in the newly added function tries to free an uninitialized pointer: drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in this function [-Werror=maybe-uninitialized] I'm adding an initialization

[PATCH] clk: stm32f4: avoid uninitialized variable access

2017-01-11 Thread Arnd Bergmann
The failure path in the newly added function tries to free an uninitialized pointer: drivers/clk/clk-stm32f4.c: In function 'stm32f4_rcc_init': drivers/clk/clk-stm32f4.c:1106:4: error: 'gate' may be used uninitialized in this function [-Werror=maybe-uninitialized] I'm adding an initialization