Re: [V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-04-07 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-04-06 08:40:15) > From: Quanyang Wang > > The round_rate callback should only perform rate calculation and not > involve calling zynqmp_pll_set_mode to change the pll mode. So let's > move zynqmp_pll_set_mode out of round_rate and to set_rate callback. >

[V2][PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-04-06 Thread quanyang . wang
From: Quanyang Wang The round_rate callback should only perform rate calculation and not involve calling zynqmp_pll_set_mode to change the pll mode. So let's move zynqmp_pll_set_mode out of round_rate and to set_rate callback. Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") Reporte

Re: [PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-03-31 Thread quanyang.wang
Hi Stephen, On 4/1/21 9:48 AM, Stephen Boyd wrote: Quoting quanyang.w...@windriver.com (2021-03-31 02:00:18) From: Quanyang Wang The round_rate callback should only perform rate calculation and not involve calling zynqmp_pll_set_mode to change the pll mode. So let's move zynqmp_pll_set_mode o

Re: [PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-03-31 Thread Stephen Boyd
Quoting quanyang.w...@windriver.com (2021-03-31 02:00:18) > From: Quanyang Wang > > The round_rate callback should only perform rate calculation and not > involve calling zynqmp_pll_set_mode to change the pll mode. So let's > move zynqmp_pll_set_mode out of round_rate and to set_rate callback. >

[PATCH] clk: zynqmp: move zynqmp_pll_set_mode out of round_rate callback

2021-03-31 Thread quanyang . wang
From: Quanyang Wang The round_rate callback should only perform rate calculation and not involve calling zynqmp_pll_set_mode to change the pll mode. So let's move zynqmp_pll_set_mode out of round_rate and to set_rate callback. Reported-by: Laurent Pinchart Signed-off-by: Quanyang Wang --- dri