RE: [PATCH] clk:mmp: clk-mix.c fix divide-by-zero

2019-03-29 Thread Nixiaoming
On 3/30/2019 6:48 AM Stephen Boyd wrote: >Quoting nixiaoming (2019-03-29 04:46:00) >> The _get_div function has a branch with a return value of 0 >> Add a check on the return value of _get_div to avoid divide-by-zero >> >> Signed-off-by: nixiaoming > >Similar questions apply here as they do on th

Re: [PATCH] clk:mmp: clk-mix.c fix divide-by-zero

2019-03-29 Thread Stephen Boyd
Quoting nixiaoming (2019-03-29 04:46:00) > The _get_div function has a branch with a return value of 0 > Add a check on the return value of _get_div to avoid divide-by-zero > > Signed-off-by: nixiaoming Similar questions apply here as they do on the generic divider patch you sent. > --- > driv

Re: [PATCH] clk:mmp: clk-mix.c fix divide-by-zero

2019-03-29 Thread Mukesh Ojha
On 3/29/2019 5:16 PM, nixiaoming wrote: The _get_div function has a branch with a return value of 0 Add a check on the return value of _get_div to avoid divide-by-zero Signed-off-by: nixiaoming Fix the below minor comments.. Otherwise things look good..you can take mine Reviewed-by: Mukesh

[PATCH] clk:mmp: clk-mix.c fix divide-by-zero

2019-03-29 Thread nixiaoming
The _get_div function has a branch with a return value of 0 Add a check on the return value of _get_div to avoid divide-by-zero Signed-off-by: nixiaoming --- drivers/clk/mmp/clk-mix.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/clk/mmp/clk-mix.c b/drivers/clk/mmp/clk-mix.c in