Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-29 Thread Mark Brown
On Thu, Mar 28, 2013 at 02:47:51PM +, Arnd Bergmann wrote: > Since we recently introduced the IS_ENABLED() macro to test for preprocessor > symbols, I think there is a general trend away from any #ifdefs in driver > code. I have to say I'm not seeing any evidence of this in the patches I'm se

Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Mark Brown wrote: > On Thu, Mar 28, 2013 at 01:08:22PM +, Arnd Bergmann wrote: > > On Thursday 28 March 2013, Mark Brown wrote: > > > > That still looks like it'll reference the function? > > > Yes, that is intentional. The idea is to create a reference to the > > f

Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Mark Brown
On Thu, Mar 28, 2013 at 01:08:22PM +, Arnd Bergmann wrote: > On Thursday 28 March 2013, Mark Brown wrote: > > That still looks like it'll reference the function? > Yes, that is intentional. The idea is to create a reference to the > function so gcc doesn't complain about unused symbols if the

Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Mark Brown wrote: > On Thu, Mar 28, 2013 at 12:39:46PM +, Arnd Bergmann wrote: > > > Axel Lin reported the same problem and I fixed the below code earlier > > today by using the correct __attribute__((unused)) and dropping the > > section magic for the non-OF case. M

Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Mark Brown
On Thu, Mar 28, 2013 at 12:39:46PM +, Arnd Bergmann wrote: > Axel Lin reported the same problem and I fixed the below code earlier > today by using the correct __attribute__((unused)) and dropping the > section magic for the non-OF case. My patch now looks contains the That still looks like i

Re: [PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Arnd Bergmann
On Thursday 28 March 2013, Mark Brown wrote: > Commit 4d10f054 (clocksource: make CLOCKSOURCE_OF_DECLARE type safe) > made CLOCKSOURCE_OF_DECLARE reference the function pointer in both the > OF and non-OF cases. In the non-OF case this is likely to introduce > build failures as users may reasonably

[PATCH] clocksource: Fix build in non-OF case

2013-03-28 Thread Mark Brown
Commit 4d10f054 (clocksource: make CLOCKSOURCE_OF_DECLARE type safe) made CLOCKSOURCE_OF_DECLARE reference the function pointer in both the OF and non-OF cases. In the non-OF case this is likely to introduce build failures as users may reasonably conditionally compile the OF specific code, either t