Re: [PATCH] closures: move to lib/

2013-12-22 Thread Christoph Hellwig
On Thu, Dec 19, 2013 at 04:21:07AM -0800, Kent Overstreet wrote: > Grep through drivers/md/bcache/... While that will require a fair amount of work I'm pretty sure we could untangle that mess as well. But what I meant was whatever piece of code that motivated you to move the code to lib/. -- To u

Re: [PATCH] closures: move to lib/

2013-12-19 Thread Tejun Heo
Hello, On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote: > > the closure code was never intended to be bcache specific - hopefully it > > can be > > useful elsewhere in the kernel. > > They are not. They aren't

Re: [PATCH] closures: move to lib/

2013-12-19 Thread Kent Overstreet
On Thu, Dec 19, 2013 at 04:19:35AM -0800, Christoph Hellwig wrote: > On Thu, Dec 19, 2013 at 04:18:30AM -0800, Kent Overstreet wrote: > > That's not really the kind of technical objection one can respond to. If > > you think there's a better way of doing this kind of asynchronous stuff, > > or a be

Re: [PATCH] closures: move to lib/

2013-12-19 Thread Christoph Hellwig
On Thu, Dec 19, 2013 at 04:18:30AM -0800, Kent Overstreet wrote: > That's not really the kind of technical objection one can respond to. If > you think there's a better way of doing this kind of asynchronous stuff, > or a better mechanism already in the kernel (ha!) - please, by all > means, enligh

Re: [PATCH] closures: move to lib/

2013-12-19 Thread Kent Overstreet
On Thu, Dec 19, 2013 at 04:05:16AM -0800, Christoph Hellwig wrote: > On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote: > > the closure code was never intended to be bcache specific - hopefully it > > can be > > useful elsewhere in the kernel. > > They are not. They aren't closures

Re: [PATCH] closures: move to lib/

2013-12-19 Thread Christoph Hellwig
On Wed, Dec 18, 2013 at 05:29:54PM -0800, Kent Overstreet wrote: > the closure code was never intended to be bcache specific - hopefully it can > be > useful elsewhere in the kernel. They are not. They aren't closures in the CS sense, and they are an ugly mess. Please work on removing them inst

Re: [PATCH] closures: move to lib/

2013-12-18 Thread Kent Overstreet
On Wed, Dec 18, 2013 at 05:34:31PM -0800, Dan Williams wrote: > On Wed, Dec 18, 2013 at 5:29 PM, Kent Overstreet wrote: > > the closure code was never intended to be bcache specific - hopefully it > > can be > > useful elsewhere in the kernel. > > > > Signed-off-by: Kent Overstreet > > Cc: Tejun

Re: [PATCH] closures: move to lib/

2013-12-18 Thread Dan Williams
On Wed, Dec 18, 2013 at 5:29 PM, Kent Overstreet wrote: > the closure code was never intended to be bcache specific - hopefully it can > be > useful elsewhere in the kernel. > > Signed-off-by: Kent Overstreet > Cc: Tejun Heo > Cc: Andrew Morton > Cc: Oleg Nesterov > Cc: Arjan van de Ven > Cc

[PATCH] closures: move to lib/

2013-12-18 Thread Kent Overstreet
the closure code was never intended to be bcache specific - hopefully it can be useful elsewhere in the kernel. Signed-off-by: Kent Overstreet Cc: Tejun Heo Cc: Andrew Morton Cc: Oleg Nesterov Cc: Arjan van de Ven Cc: Dan Williams --- drivers/md/bcache/Kconfig | 9 - drivers/md/bcache/M