Re: [PATCH] common/rc: Fix _check_s_dax()

2020-12-03 Thread Ira Weiny
On Thu, Dec 03, 2020 at 07:08:39PM +0100, Christoph Hellwig wrote: > On Thu, Dec 03, 2020 at 11:55:50AM -0600, Eric Sandeen wrote: > > *nod* and my suggestion was to explicitly test for the old/wrong value and > > offer the test-runner a hint about why it may have been set (missing the > > fix comm

Re: [PATCH] common/rc: Fix _check_s_dax()

2020-12-03 Thread Christoph Hellwig
On Thu, Dec 03, 2020 at 11:55:50AM -0600, Eric Sandeen wrote: > *nod* and my suggestion was to explicitly test for the old/wrong value and > offer the test-runner a hint about why it may have been set (missing the > fix commit), but we should still ultimately fail the test when it is seen. Yes, th

Re: [PATCH] common/rc: Fix _check_s_dax()

2020-12-03 Thread Eric Sandeen
On 12/3/20 2:15 AM, Christoph Hellwig wrote: > On Wed, Dec 02, 2020 at 01:41:45PM -0800, ira.we...@intel.com wrote: >> From: Ira Weiny >> >> There is a conflict with the user visible statx bits 'mount root' and >> 'dax'. The kernel is changing the dax bit to correct this conflict.[1] >> >> Adj

Re: [PATCH] common/rc: Fix _check_s_dax()

2020-12-03 Thread Christoph Hellwig
On Wed, Dec 02, 2020 at 01:41:45PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > There is a conflict with the user visible statx bits 'mount root' and > 'dax'. The kernel is changing the dax bit to correct this conflict.[1] > > Adjust _check_s_dax() to use the new bit. Because DAX te

[PATCH] common/rc: Fix _check_s_dax()

2020-12-02 Thread ira . weiny
From: Ira Weiny There is a conflict with the user visible statx bits 'mount root' and 'dax'. The kernel is changing the dax bit to correct this conflict.[1] Adjust _check_s_dax() to use the new bit. Because DAX tests do not run on root mounts, STATX_ATTR_MOUNT_ROOT should always be 0, therefor

Re: [RFC PATCH] common/rc: Fix _check_s_dax() for kernel 5.10

2020-12-02 Thread Ira Weiny
On Wed, Dec 02, 2020 at 11:10:50AM -0600, Eric Sandeen wrote: > On 12/2/20 10:07 AM, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > There is a conflict with the user visible statx bits 'mount root' and > > 'dax'. The kernel is shifting the dax bit.[1] > > > > Adjust _check_s_dax() to us

Re: [RFC PATCH] common/rc: Fix _check_s_dax() for kernel 5.10

2020-12-02 Thread Christoph Hellwig
On Wed, Dec 02, 2020 at 11:10:50AM -0600, Eric Sandeen wrote: > xfstests gets used on distro kernels too, so relying on kernel version isn't > really something we can use to make determinations like this, unfortunately. > > Probably the best we can do is hope that the change makes it to stable and

Re: [RFC PATCH] common/rc: Fix _check_s_dax() for kernel 5.10

2020-12-02 Thread Eric Sandeen
On 12/2/20 10:07 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > There is a conflict with the user visible statx bits 'mount root' and > 'dax'. The kernel is shifting the dax bit.[1] > > Adjust _check_s_dax() to use the new bit. > > [1] > https://lore.kernel.org/lkml/3e28d2c7-fbe5-298a-1

[RFC PATCH] common/rc: Fix _check_s_dax() for kernel 5.10

2020-12-02 Thread ira . weiny
From: Ira Weiny There is a conflict with the user visible statx bits 'mount root' and 'dax'. The kernel is shifting the dax bit.[1] Adjust _check_s_dax() to use the new bit. [1] https://lore.kernel.org/lkml/3e28d2c7-fbe5-298a-13ba-dcd8fd504...@redhat.com/ Signed-off-by: Ira Weiny --- I'm