Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-22 Thread Sodagudi Prasad
On 2017-06-22 02:43, Mark Rutland wrote: On Tue, Jun 20, 2017 at 04:12:32PM -0700, David Rientjes wrote: On Tue, 20 Jun 2017, Mark Rutland wrote: > As with my reply to David, my preference would be that we: > > 1) Align compiler-clang.h with the compiler-gcc.h inlining behaviour, so >that t

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-22 Thread Mark Rutland
On Tue, Jun 20, 2017 at 04:12:32PM -0700, David Rientjes wrote: > On Tue, 20 Jun 2017, Mark Rutland wrote: > > > As with my reply to David, my preference would be that we: > > > > 1) Align compiler-clang.h with the compiler-gcc.h inlining behaviour, so > >that things work by default. > > > >

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-20 Thread David Rientjes
On Tue, 20 Jun 2017, Mark Rutland wrote: > As with my reply to David, my preference would be that we: > > 1) Align compiler-clang.h with the compiler-gcc.h inlining behaviour, so >that things work by default. > > 2) Fix up the arm64 core code (and drivers for architected / common >periph

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-20 Thread Mark Rutland
On Mon, Jun 19, 2017 at 03:19:27PM -0700, Sodagudi Prasad wrote: > On 2017-06-19 14:42, David Rientjes wrote: > >Yes, the arch/arm64/include/asm/cmpxchg.h instance appears to need > >__always_inline as several other functions need __always_inline in > >arch/arm64/include/*. It's worth making that

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-20 Thread Mark Rutland
On Mon, Jun 19, 2017 at 02:42:23PM -0700, David Rientjes wrote: > On Mon, 19 Jun 2017, Sodagudi Prasad wrote: > > > > > Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused > > > > static inline functions") re-defining the 'inline' macro but > > > > __attribute__((always_inline)) is

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-19 Thread Sodagudi Prasad
On 2017-06-19 14:42, David Rientjes wrote: On Mon, 19 Jun 2017, Sodagudi Prasad wrote: > > Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused > > static inline functions") re-defining the 'inline' macro but > > __attribute__((always_inline)) is missing. Some compilers may > > no

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-19 Thread David Rientjes
On Mon, 19 Jun 2017, Sodagudi Prasad wrote: > > > Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused > > > static inline functions") re-defining the 'inline' macro but > > > __attribute__((always_inline)) is missing. Some compilers may > > > not honor inline hint if always_iniline

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-19 Thread Sodagudi Prasad
On 2017-06-19 13:25, David Rientjes wrote: On Mon, 19 Jun 2017, Prasad Sodagudi wrote: Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused static inline functions") re-defining the 'inline' macro but __attribute__((always_inline)) is missing. Some compilers may not honor inline h

Re: [PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-19 Thread David Rientjes
On Mon, 19 Jun 2017, Prasad Sodagudi wrote: > Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused > static inline functions") re-defining the 'inline' macro but > __attribute__((always_inline)) is missing. Some compilers may > not honor inline hint if always_iniline attribute not th

[PATCH] compiler, clang: Add always_inline attribute to inline

2017-06-19 Thread Prasad Sodagudi
Commit abb2ea7dfd82 ("compiler, clang: suppress warning for unused static inline functions") re-defining the 'inline' macro but __attribute__((always_inline)) is missing. Some compilers may not honor inline hint if always_iniline attribute not there. So add always_inline attribute to inline as done