Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread mancha security
On Wed, Apr 29, 2015 at 12:40:15PM -0400, Pranith Kumar wrote: > On Wed, Apr 29, 2015 at 10:59 AM, mancha security > wrote: > > > > The problem is that ICC defines __GNUC__ so barrier() gets defined > > in compiler-gcc.h. Your commit removed an #undef from > > compiler-intel.h so compiler.h will n

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Pranith Kumar
On Wed, Apr 29, 2015 at 12:59 PM, Daniel Borkmann wrote: > On 04/29/2015 06:40 PM, Pranith Kumar wrote: >> >> On Wed, Apr 29, 2015 at 10:59 AM, mancha security >> wrote: >>> >>> >>> The problem is that ICC defines __GNUC__ so barrier() gets defined >>> in compiler-gcc.h. Your commit removed an #u

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Daniel Borkmann
On 04/29/2015 06:40 PM, Pranith Kumar wrote: On Wed, Apr 29, 2015 at 10:59 AM, mancha security wrote: The problem is that ICC defines __GNUC__ so barrier() gets defined in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h so compiler.h will never define barrier to __memory_ba

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Pranith Kumar
On Wed, Apr 29, 2015 at 10:59 AM, mancha security wrote: > > The problem is that ICC defines __GNUC__ so barrier() gets defined > in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h > so compiler.h will never define barrier to __memory_barrier(). > OK, I see your point. But, IC

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Daniel Borkmann
On 04/29/2015 04:51 PM, Pranith Kumar wrote: ... message says in 73679e508201(your commit message has the wrong hash). Sorry for that, the Fixes tag actually got it right. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kerne

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread mancha security
On Wed, Apr 29, 2015 at 10:51:40AM -0400, Pranith Kumar wrote: > Hi Daniel, > > On Wed, Apr 29, 2015 at 10:42 AM, Daniel Borkmann > wrote: > > Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate > > definition") removed the double definition of __memory_barrier() > > intrinsics. > >

Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Pranith Kumar
Hi Daniel, On Wed, Apr 29, 2015 at 10:42 AM, Daniel Borkmann wrote: > Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate > definition") removed the double definition of __memory_barrier() > intrinsics. > > However, in doing so, it also removed the preceding #undef barrier, > meaning,

[PATCH] compiler-intel: fix wrong compiler barrier() macro

2015-04-29 Thread Daniel Borkmann
Cleanup commit 23ebdedc67e ("compiler-intel.h: Remove duplicate definition") removed the double definition of __memory_barrier() intrinsics. However, in doing so, it also removed the preceding #undef barrier, meaning, the actual barrier() macro from compiler-gcc.h with inline asm is still in place