Re: [PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-16 Thread Arvind Sankar
On Fri, Oct 16, 2020 at 08:13:44AM +, David Laight wrote: > From: Arvind Sankar > > Sent: 15 October 2020 23:01 > ,,, > > I think it's helpful to have the more detailed explanation about > > register variables -- at first glance, it's a bit mystifying as to why > > the compiler would think

RE: [PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-16 Thread David Laight
From: Arvind Sankar > Sent: 15 October 2020 23:01 ,,, > I think it's helpful to have the more detailed explanation about > register variables -- at first glance, it's a bit mystifying as to why > the compiler would think that the asm can't access the stack. Spilling > registers to the stack is

Re: [PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-15 Thread Arvind Sankar
On Thu, Oct 15, 2020 at 09:09:11PM +, David Laight wrote: > From: Arvind Sankar > > Sent: 15 October 2020 19:14 > > > > Be clear about @ptr vs the variable that @ptr points to, and add some > > more details as to why the special barrier_data() macro is required. > > > > Signed-off-by: Arvind

RE: [PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-15 Thread David Laight
From: Arvind Sankar > Sent: 15 October 2020 19:14 > > Be clear about @ptr vs the variable that @ptr points to, and add some > more details as to why the special barrier_data() macro is required. > > Signed-off-by: Arvind Sankar > --- > include/linux/compiler.h | 33

Re: [PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-15 Thread Nick Desaulniers
On Thu, Oct 15, 2020 at 11:13 AM Arvind Sankar wrote: > > Be clear about @ptr vs the variable that @ptr points to, and add some > more details as to why the special barrier_data() macro is required. > > Signed-off-by: Arvind Sankar Thanks for this distinct cleanup. Acked-by: Nick Desaulniers

[PATCH] compiler.h: Clarify comment about the need for barrier_data()

2020-10-15 Thread Arvind Sankar
Be clear about @ptr vs the variable that @ptr points to, and add some more details as to why the special barrier_data() macro is required. Signed-off-by: Arvind Sankar --- include/linux/compiler.h | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff