Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-27 Thread Miguel Ojeda
On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). > > A lot of warn_unused_result warnings existed in 2006, but until now > they have been fixed thanks to people doing allmodconfig tests. > > Our goal is to always enable __must_

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-23 Thread Miguel Ojeda
On Mon, Nov 23, 2020 at 4:37 AM Masahiro Yamada wrote: > > I can move it to compiler_attribute.h > > This attribute is supported by gcc, clang, and icc. > https://godbolt.org/z/ehd6so > > I can send v2. > > I do not mind renaming, but it should be done in a separate patch. Of course -- sorry, I d

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-22 Thread Masahiro Yamada
On Sun, Nov 22, 2020 at 5:45 AM Miguel Ojeda wrote: > > On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > > > Our goal is to always enable __must_check where appreciate, so this > > CONFIG option is no longer needed. > > This would be great. It also implies we can then move it to > `comp

Re: [PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-21 Thread Miguel Ojeda
On Sat, Nov 21, 2020 at 8:44 PM Masahiro Yamada wrote: > > Our goal is to always enable __must_check where appreciate, so this > CONFIG option is no longer needed. This would be great. It also implies we can then move it to `compiler_attributes.h` since it does not depend on config options anymor

[PATCH] compiler_attribute: remove CONFIG_ENABLE_MUST_CHECK

2020-11-21 Thread Masahiro Yamada
Revert commit cebc04ba9aeb ("add CONFIG_ENABLE_MUST_CHECK"). A lot of warn_unused_result warnings existed in 2006, but until now they have been fixed thanks to people doing allmodconfig tests. Our goal is to always enable __must_check where appreciate, so this CONFIG option is no longer needed.