Re: [PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-14 Thread Daniel P. Berrange
On Thu, Dec 13, 2012 at 09:49:39PM -0500, Neil Horman wrote: > On Thu, Dec 13, 2012 at 02:25:34PM -0800, Andrew Morton wrote: > > On Thu, 13 Dec 2012 13:12:20 -0500 > > Neil Horman wrote: > > > > > On Thu, Dec 13, 2012 at 06:20:48AM -0600, Serge Hallyn wrote: > > > > Quoting Neil Horman (nhor...@

Re: [PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-13 Thread Neil Horman
On Thu, Dec 13, 2012 at 02:25:34PM -0800, Andrew Morton wrote: > On Thu, 13 Dec 2012 13:12:20 -0500 > Neil Horman wrote: > > > On Thu, Dec 13, 2012 at 06:20:48AM -0600, Serge Hallyn wrote: > > > Quoting Neil Horman (nhor...@tuxdriver.com): > > > > Theres one problem I currently see with it, and t

Re: [PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-13 Thread Andrew Morton
On Thu, 13 Dec 2012 13:12:20 -0500 Neil Horman wrote: > On Thu, Dec 13, 2012 at 06:20:48AM -0600, Serge Hallyn wrote: > > Quoting Neil Horman (nhor...@tuxdriver.com): > > > Theres one problem I currently see with it, and that is that I'm not sure > > > we can > > > change the current behavior of

Re: [PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-13 Thread Neil Horman
On Thu, Dec 13, 2012 at 06:20:48AM -0600, Serge Hallyn wrote: > Quoting Neil Horman (nhor...@tuxdriver.com): > > Theres one problem I currently see with it, and that is that I'm not sure > > we can > > change the current behavior of how the root fs is set for the pipe reader, > > lest > > we brea

Re: [PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-13 Thread Serge Hallyn
Quoting Neil Horman (nhor...@tuxdriver.com): > Theres one problem I currently see with it, and that is that I'm not sure we > can > change the current behavior of how the root fs is set for the pipe reader, > lest > we break some user space expectations. As such, I've added a sysctl in this > pat

[PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-11 Thread Neil Horman
As its currently implemented, redirection of core dumps to a pipe reader should be executed such that the reader runs in the namespace of the crashing process, and it currently does not. This is the only sane way to deal with namespaces properly it seems to me, and this patch implements that functi

[RFC PATCH] core_pattern: set core helpers root and namespace to crashing process

2012-12-04 Thread Neil Horman
As its currently implemented, redirection of core dumps to a pipe reader should be executed such that the reader runs in the namespace of the crashing process, and it currently does not. This is the only sane way to deal with namespaces properly it seems to me, and this patch implements that functi