Re: [PATCH] coredump: fix va_list corruption

2014-04-19 Thread Neil Horman
On Sat, Apr 19, 2014 at 10:15:07AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > A va_list needs to be copied in case it needs to be used twice. > > Thanks to Hugh for debugging this issue, leading to various panics. > > Tested: > > lpq84:~# echo "|/foobar12345 %h %h %h %h %h %h %h %h %h

Re: [PATCH] coredump: fix va_list corruption

2014-04-19 Thread Oleg Nesterov
On 04/19, Eric Dumazet wrote: > > A va_list needs to be copied in case it needs to be used twice. OOPS :/ > --- a/fs/coredump.c > +++ b/fs/coredump.c > @@ -73,10 +73,15 @@ static int expand_corename(struct core_name *cn, int size) > static int cn_vprintf(struct core_name *cn, const char *fmt, va

[PATCH] coredump: fix va_list corruption

2014-04-19 Thread Eric Dumazet
From: Eric Dumazet A va_list needs to be copied in case it needs to be used twice. Thanks to Hugh for debugging this issue, leading to various panics. Tested: lpq84:~# echo "|/foobar12345 %h %h %h %h %h %h %h %h %h %h %h %h %h %h % h %h %h %h %h %h" >/proc/sys/kernel/core_pattern 'produce_cor