Re: [PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Mathieu Poirier
On Thu, Aug 13, 2020 at 12:04:55PM +0200, Mian Yousaf Kaukab wrote: > Since port-numbers start from 0, add 1 to port-number to get the port > count. > > Fix following crash when Coresight is enabled on ACPI based systems: > > [ 61.061736] Unable to handle kernel NULL pointer dereference at virt

Re: [PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Jeremy Linton
Hi, As Suzuki mentioned, I hit this on the N1SDP, and as of yesterday afternoon was running a patch that is identical to what you posted here. This fixes the boot failure and WARN_ON's I was seeing, and appears to return the N1SDP to basic functionality. I think there is at least one further

Re: [PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Suzuki K Poulose
On 08/13/2020 11:04 AM, Mian Yousaf Kaukab wrote: Since port-numbers start from 0, add 1 to port-number to get the port count. Fix following crash when Coresight is enabled on ACPI based systems: [ 61.061736] Unable to handle kernel NULL pointer dereference at virtual address 000

[PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Mian Yousaf Kaukab
Since port-numbers start from 0, add 1 to port-number to get the port count. Fix following crash when Coresight is enabled on ACPI based systems: [ 61.061736] Unable to handle kernel NULL pointer dereference at virtual address 0008 ... [ 61.135494] pc : acpi_coresight_parse_graph

[PATCH] coresight: fix offset by one error in counting ports

2020-08-13 Thread Mian Yousaf Kaukab
Since port-numbers start from 0, add 1 to port-number to get the port count. Fix following crash when Coresight is enabled on ACPI based systems: [ 61.061736] Unable to handle kernel NULL pointer dereference at virtual address 0008 ... [ 61.135494] pc : acpi_coresight_parse_graph