Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-13 Thread Russell King
On Fri, Aug 12, 2005 at 08:46:17PM +0100, Russell King wrote: > On Fri, Aug 12, 2005 at 11:32:57AM -0500, Kumar Gala wrote: > > The lack of spin_lock_init causes badness in the preempt configuration. > > Please don't - I have a patch in the wings which fixes this properly. > Unfortunately, its beh

Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-13 Thread Alan Cox
On Gwe, 2005-08-12 at 14:58 -0700, David S. Miller wrote: > I like this a lot, and the count return based error handling > is nice as well. Should a driver sink any bytes that the > TTY flip interface couldn't eat or should it just wait for > the overrun event? Its really driver dependant. A lot

Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-12 Thread David S. Miller
From: Alan Cox <[EMAIL PROTECTED]> Date: Fri, 12 Aug 2005 23:03:05 +0100 > http://zeniv.linux.org.uk/~alan/serial.diff I like this a lot, and the count return based error handling is nice as well. Should a driver sink any bytes that the TTY flip interface couldn't eat or should it just wait for

Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-12 Thread Alan Cox
On Gwe, 2005-08-12 at 20:46 +0100, Russell King wrote: > (Since Linus pulled the shutters down when I still had a large chunk > of stuff in my serial tree, my serial patch merging is currently at > a complete standstill.) Well in the mean time for some more amusement see what you think of http://

Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-12 Thread Kumar Gala
On Aug 12, 2005, at 2:46 PM, Russell King wrote: On Fri, Aug 12, 2005 at 11:32:57AM -0500, Kumar Gala wrote: The lack of spin_lock_init causes badness in the preempt configuration. Please don't - I have a patch in the wings which fixes this properly. Unfortunately, its behind a ton of ot

Re: [PATCH] cpm_uart: Fix spinlock initialization

2005-08-12 Thread Russell King
On Fri, Aug 12, 2005 at 11:32:57AM -0500, Kumar Gala wrote: > The lack of spin_lock_init causes badness in the preempt configuration. Please don't - I have a patch in the wings which fixes this properly. Unfortunately, its behind a ton of other patches, and I don't want to try to find all these fi

[PATCH] cpm_uart: Fix spinlock initialization

2005-08-12 Thread Kumar Gala
The lack of spin_lock_init causes badness in the preempt configuration. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- commit d6dee08c314c1952921adc99e8f5ff6c332341ef tree 96ca76ab7d75cf808287af50c88ed7d1aed49923 parent 51a75dcea8fe0407f06467de3