Re: [PATCH] cpu/hotplug: Fix acquire of st->should_run in cpuhp_thread_fun()

2018-09-05 Thread Peter Zijlstra
On Wed, Sep 05, 2018 at 11:22:07AM +0530, Neeraj Upadhyay wrote: > The smp_mb() in cpuhp_thread_fun() appears to be misplaced, and > need to be after the load of st->should_run, to prevent > reordering of the later load/stores w.r.t. the load of > st->should_run. I'm tempted to say this changelog

Re: [PATCH] cpu/hotplug: Fix acquire of st->should_run in cpuhp_thread_fun()

2018-09-05 Thread Peter Zijlstra
On Wed, Sep 05, 2018 at 11:22:07AM +0530, Neeraj Upadhyay wrote: > The smp_mb() in cpuhp_thread_fun() appears to be misplaced, and > need to be after the load of st->should_run, to prevent > reordering of the later load/stores w.r.t. the load of > st->should_run. I'm tempted to say this changelog

[PATCH] cpu/hotplug: Fix acquire of st->should_run in cpuhp_thread_fun()

2018-09-04 Thread Neeraj Upadhyay
The smp_mb() in cpuhp_thread_fun() appears to be misplaced, and need to be after the load of st->should_run, to prevent reordering of the later load/stores w.r.t. the load of st->should_run. Signed-off-by: Neeraj Upadhyay --- kernel/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] cpu/hotplug: Fix acquire of st->should_run in cpuhp_thread_fun()

2018-09-04 Thread Neeraj Upadhyay
The smp_mb() in cpuhp_thread_fun() appears to be misplaced, and need to be after the load of st->should_run, to prevent reordering of the later load/stores w.r.t. the load of st->should_run. Signed-off-by: Neeraj Upadhyay --- kernel/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3