Re: [PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-09 Thread Rafael J. Wysocki
On Thursday, July 09, 2015 10:43:56 AM Viresh Kumar wrote: > On 09-07-15, 02:40, Rafael J. Wysocki wrote: > > The above sentence is completely unclear to anyone unfamiliar with the > > code in question. > > > > The fix is to access the policy data structure for the given CPU directly > > (which al

Re: [PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-08 Thread Viresh Kumar
On 09-07-15, 02:40, Rafael J. Wysocki wrote: > The above sentence is completely unclear to anyone unfamiliar with the > code in question. > > The fix is to access the policy data structure for the given CPU directly > (which also returns a valid policy for offline CPUs), but the policy > itself ha

Re: [PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-08 Thread Rafael J. Wysocki
On Wednesday, July 08, 2015 01:08:15 PM Viresh Kumar wrote: > Users of freq table may want to access it for any CPU from > policy->related_cpus mask. One such user is cpu-cooling layer. It gets a > list of 'clip_cpus' (equivalent to policy->related_cpus) during > registration and tries to get freq_

Re: [PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-08 Thread Javi Merino
Hi Viresh, one minor nit below On Wed, Jul 08, 2015 at 08:38:15AM +0100, Viresh Kumar wrote: > Users of freq table may want to access it for any CPU from > policy->related_cpus mask. One such user is cpu-cooling layer. It gets a > list of 'clip_cpus' (equivalent to policy->related_cpus) during >

Re: [PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-08 Thread Pi-Cheng Chen
On Wed, Jul 8, 2015 at 3:38 PM, Viresh Kumar wrote: > Users of freq table may want to access it for any CPU from > policy->related_cpus mask. One such user is cpu-cooling layer. It gets a > list of 'clip_cpus' (equivalent to policy->related_cpus) during > registration and tries to get freq_table f

[PATCH] cpufreq: Allow accessing freq_table for offline CPUs

2015-07-08 Thread Viresh Kumar
Users of freq table may want to access it for any CPU from policy->related_cpus mask. One such user is cpu-cooling layer. It gets a list of 'clip_cpus' (equivalent to policy->related_cpus) during registration and tries to get freq_table for the first CPU of this mask. If the CPU, for which it trie