Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-18 Thread Rafael J. Wysocki
On Friday, August 18, 2017 6:19:44 AM CEST Viresh Kumar wrote: > On 17-08-17, 17:31, Rafael J. Wysocki wrote: > > On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > > > The callers already have the structure (struct update_util_data) where > > > the function pointer is saved by

Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-18 Thread Rafael J. Wysocki
On Friday, August 18, 2017 6:19:44 AM CEST Viresh Kumar wrote: > On 17-08-17, 17:31, Rafael J. Wysocki wrote: > > On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > > > The callers already have the structure (struct update_util_data) where > > > the function pointer is saved by

Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Viresh Kumar
On 17-08-17, 17:31, Rafael J. Wysocki wrote: > On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > > The callers already have the structure (struct update_util_data) where > > the function pointer is saved by cpufreq_add_update_util_hook(). And its > > better if the callers fill it

Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Viresh Kumar
On 17-08-17, 17:31, Rafael J. Wysocki wrote: > On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > > The callers already have the structure (struct update_util_data) where > > the function pointer is saved by cpufreq_add_update_util_hook(). And its > > better if the callers fill it

Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Rafael J. Wysocki
On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > The callers already have the structure (struct update_util_data) where > the function pointer is saved by cpufreq_add_update_util_hook(). And its > better if the callers fill it themselves, as they can do it from the >

Re: [PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Rafael J. Wysocki
On Thursday, August 17, 2017 2:04:48 PM CEST Viresh Kumar wrote: > The callers already have the structure (struct update_util_data) where > the function pointer is saved by cpufreq_add_update_util_hook(). And its > better if the callers fill it themselves, as they can do it from the >

[PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Viresh Kumar
The callers already have the structure (struct update_util_data) where the function pointer is saved by cpufreq_add_update_util_hook(). And its better if the callers fill it themselves, as they can do it from the governor->init() callback then, which is called only once per policy lifetime rather

[PATCH] cpufreq: Don't send callback pointer to cpufreq_add_update_util_hook()

2017-08-17 Thread Viresh Kumar
The callers already have the structure (struct update_util_data) where the function pointer is saved by cpufreq_add_update_util_hook(). And its better if the callers fill it themselves, as they can do it from the governor->init() callback then, which is called only once per policy lifetime rather