Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-22 Thread Rafael J. Wysocki
On Tuesday, October 22, 2013 06:12:08 AM Viresh Kumar wrote: > On 22 October 2013 04:09, Rafael J. Wysocki wrote: > > I don't think I've missed it. It should be commit 1bab64d in my tree. > > I fetched your tree yesterday and this wasn't there in linux-next or > bleeding-edge branch.. When I

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-22 Thread Rafael J. Wysocki
On Tuesday, October 22, 2013 06:12:08 AM Viresh Kumar wrote: On 22 October 2013 04:09, Rafael J. Wysocki r...@sisk.pl wrote: I don't think I've missed it. It should be commit 1bab64d in my tree. I fetched your tree yesterday and this wasn't there in linux-next or bleeding-edge branch..

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Viresh Kumar
On 22 October 2013 04:09, Rafael J. Wysocki wrote: > I don't think I've missed it. It should be commit 1bab64d in my tree. I fetched your tree yesterday and this wasn't there in linux-next or bleeding-edge branch.. When I fetched it now again, it is there.. Thanks. -- To unsubscribe from this

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Rafael J. Wysocki
On Monday, October 21, 2013 12:43:32 PM Viresh Kumar wrote: > On 13 October 2013 06:07, Viresh Kumar wrote: > > On 13/10/2013, Rafael J. Wysocki wrote: > >> -> What about this: > >> > >> /* > >>* The core will not set policy->cur, because cpufreq_driver->get is > >> NULL, > >>

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Viresh Kumar
On 13 October 2013 06:07, Viresh Kumar wrote: > On 13/10/2013, Rafael J. Wysocki wrote: >> -> What about this: >> >> /* >>* The core will not set policy->cur, because cpufreq_driver->get is >> NULL, >>* so we need to set it here. However, we have to guess it, because >>

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Viresh Kumar
On 13 October 2013 06:07, Viresh Kumar viresh.ku...@linaro.org wrote: On 13/10/2013, Rafael J. Wysocki r...@sisk.pl wrote: - What about this: /* * The core will not set policy-cur, because cpufreq_driver-get is NULL, * so we need to set it here. However, we have to

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Rafael J. Wysocki
On Monday, October 21, 2013 12:43:32 PM Viresh Kumar wrote: On 13 October 2013 06:07, Viresh Kumar viresh.ku...@linaro.org wrote: On 13/10/2013, Rafael J. Wysocki r...@sisk.pl wrote: - What about this: /* * The core will not set policy-cur, because cpufreq_driver-get is

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-21 Thread Viresh Kumar
On 22 October 2013 04:09, Rafael J. Wysocki r...@sisk.pl wrote: I don't think I've missed it. It should be commit 1bab64d in my tree. I fetched your tree yesterday and this wasn't there in linux-next or bleeding-edge branch.. When I fetched it now again, it is there.. Thanks. -- To unsubscribe

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Viresh Kumar
Sat, 12 Oct 2013 07:00:01 +0530 Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq dr

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Rafael J. Wysocki
On Saturday, October 12, 2013 08:58:10 PM Viresh Kumar wrote: > On 12/10/2013, Rafael J. Wysocki wrote: > > Well, please merge it with the existing comment and use the usual format > > for comments that are longer than two lines. > > I thought these are separate comments and so keeping them

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Viresh Kumar
cb9ef81b50eb5e8559f7d132ef46803c8272091 Mon Sep 17 00:00:00 2001 Message-Id: From: Viresh Kumar Date: Sat, 12 Oct 2013 07:00:01 +0530 Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case policy->cur is now set by cpufreq core when cpufreq_driver->get() is

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Rafael J. Wysocki
On Saturday, October 12, 2013 07:06:03 AM Viresh Kumar wrote: > policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined > and > so drivers aren't required to set it. When space_id is > ACPI_ADR_SPACE_SYSTEM_IO > for acpi cpufreq driver it doesn't set ->get to a valid

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Rafael J. Wysocki
On Saturday, October 12, 2013 07:06:03 AM Viresh Kumar wrote: policy-cur is now set by cpufreq core when cpufreq_driver-get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq driver it doesn't set -get to a valid function

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Viresh Kumar
: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case policy-cur is now set by cpufreq core when cpufreq_driver-get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq driver it doesn't set -get to a valid function pointer and so policy-cur

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Rafael J. Wysocki
On Saturday, October 12, 2013 08:58:10 PM Viresh Kumar wrote: On 12/10/2013, Rafael J. Wysocki r...@sisk.pl wrote: Well, please merge it with the existing comment and use the usual format for comments that are longer than two lines. I thought these are separate comments and so keeping them

Re: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-12 Thread Viresh Kumar
:01 +0530 Subject: [PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case policy-cur is now set by cpufreq core when cpufreq_driver-get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq driver it doesn't set -get

[PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-11 Thread Viresh Kumar
policy->cur is now set by cpufreq core when cpufreq_driver->get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq driver it doesn't set ->get to a valid function pointer and so policy->cur is required to be set by driver. This is

[PATCH] cpufreq: acpi: Add comment under ACPI_ADR_SPACE_SYSTEM_IO case

2013-10-11 Thread Viresh Kumar
policy-cur is now set by cpufreq core when cpufreq_driver-get() is defined and so drivers aren't required to set it. When space_id is ACPI_ADR_SPACE_SYSTEM_IO for acpi cpufreq driver it doesn't set -get to a valid function pointer and so policy-cur is required to be set by driver. This is already