Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Pavel Machek
On Mon 2014-06-09 10:54:17, Viresh Kumar wrote: > 'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be > friendly towards latency-sensitive bursty workloads). > > It actually is a bit redundant as we also have 'prev_load' which can store any > integer value and can be

Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Viresh Kumar
On 9 June 2014 12:36, Srivatsa S. Bhat wrote: > On 06/09/2014 10:54 AM, Viresh Kumar wrote: > Well, to be honest, I'm not a great fan of writing tricky code (i.e., > overloading multiple semantics onto one single thing). However, in this case, I am somewhat, but it shouldn't be confusing at

Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Srivatsa S. Bhat
On 06/09/2014 10:54 AM, Viresh Kumar wrote: > 'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be > friendly towards latency-sensitive bursty workloads). > > It actually is a bit redundant as we also have 'prev_load' which can store any > integer value and can be used

Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Srivatsa S. Bhat
On 06/09/2014 10:54 AM, Viresh Kumar wrote: 'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be friendly towards latency-sensitive bursty workloads). It actually is a bit redundant as we also have 'prev_load' which can store any integer value and can be used instead

Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Viresh Kumar
On 9 June 2014 12:36, Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com wrote: On 06/09/2014 10:54 AM, Viresh Kumar wrote: Well, to be honest, I'm not a great fan of writing tricky code (i.e., overloading multiple semantics onto one single thing). However, in this case, I am somewhat, but it

Re: [PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-09 Thread Pavel Machek
On Mon 2014-06-09 10:54:17, Viresh Kumar wrote: 'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be friendly towards latency-sensitive bursty workloads). It actually is a bit redundant as we also have 'prev_load' which can store any integer value and can be used

[PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-08 Thread Viresh Kumar
'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be friendly towards latency-sensitive bursty workloads). It actually is a bit redundant as we also have 'prev_load' which can store any integer value and can be used instead of 'copy_prev_load' by setting it to zero when

[PATCH] cpufreq: governor: remove copy_prev_load from 'struct cpu_dbs_common_info'

2014-06-08 Thread Viresh Kumar
'copy_prev_load' was recently added by commit: 18b46ab (cpufreq: governor: Be friendly towards latency-sensitive bursty workloads). It actually is a bit redundant as we also have 'prev_load' which can store any integer value and can be used instead of 'copy_prev_load' by setting it to zero when