Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-26 Thread Viresh Kumar
On 20-02-19, 16:44, Viresh Kumar wrote: > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > 256"), we have started getting following compilation warning: > > qcom-cpufreq-kryo.c:168:1: warning: the frame size of 2160 bytes is larger > than 2048 bytes [-Wframe-larger-than=

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Viresh Kumar
On 21-02-19, 10:02, Amit Kucheria wrote: > Perhaps I was just unfamiliar with the dev_pm_opp_set_supported_hw() > API where the actual allocation happens 3 levels deep. Maybe the > comment should apply to dev_pm_opp_set_supported_hw(). I leave it to > you to decide. I think we are fine without any

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Amit Kucheria
On Thu, Feb 21, 2019 at 9:15 AM Viresh Kumar wrote: > > On 20-02-19, 21:56, Amit Kucheria wrote: > > On Wed, Feb 20, 2019 at 4:44 PM Viresh Kumar > > wrote: > > > > > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > > > 256"), we have started getting following compila

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Viresh Kumar
On 20-02-19, 21:56, Amit Kucheria wrote: > On Wed, Feb 20, 2019 at 4:44 PM Viresh Kumar wrote: > > > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > > 256"), we have started getting following compilation warning: > > > > qcom-cpufreq-kryo.c:168:1: warning: the frame si

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Amit Kucheria
On Wed, Feb 20, 2019 at 4:44 PM Viresh Kumar wrote: > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > 256"), we have started getting following compilation warning: > > qcom-cpufreq-kryo.c:168:1: warning: the frame size of 2160 bytes is larger > than 2048 bytes [-Wfram

Re: [PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Arnd Bergmann
On Wed, Feb 20, 2019 at 12:14 PM Viresh Kumar wrote: > > With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to > 256"), we have started getting following compilation warning: > > qcom-cpufreq-kryo.c:168:1: warning: the frame size of 2160 bytes is larger > than 2048 bytes [-Wfra

[PATCH] cpufreq: kyro: Reduce frame-size of qcom_cpufreq_kryo_probe()

2019-02-20 Thread Viresh Kumar
With the introduction of commit 846a415bf440 ("arm64: default NR_CPUS to 256"), we have started getting following compilation warning: qcom-cpufreq-kryo.c:168:1: warning: the frame size of 2160 bytes is larger than 2048 bytes [-Wframe-larger-than=] Fix that by dynamically allocating opp_tables a