Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-08 Thread Rafael J. Wysocki
On Wednesday, April 02, 2014 10:14:24 AM Viresh Kumar wrote: > Earlier commit: > commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656 > Author: Viresh Kumar > Date: Thu Jan 9 20:38:43 2014 +0530 > > cpufreq: introduce cpufreq_generic_get() routine > > did some changes

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-08 Thread Rafael J. Wysocki
On Wednesday, April 02, 2014 10:14:24 AM Viresh Kumar wrote: Earlier commit: commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656 Author: Viresh Kumar viresh.ku...@linaro.org Date: Thu Jan 9 20:38:43 2014 +0530 cpufreq: introduce cpufreq_generic_get() routine did

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-04 Thread Alexandre Oliva
On Apr 3, 2014, Viresh Kumar wrote: > On 3 April 2014 18:10, Alexandre Oliva wrote: >> FWIW, the same mistake is present in at32. > I will check others as well now :) Thanks! >> Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes >> cpufreq work again, as opposed to

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-04 Thread Alexandre Oliva
On Apr 3, 2014, Viresh Kumar viresh.ku...@linaro.org wrote: On 3 April 2014 18:10, Alexandre Oliva ol...@gnu.org wrote: FWIW, the same mistake is present in at32. I will check others as well now :) Thanks! Reverting all the changes to loongson2_cpufreq.c in 652ed95d5fa makes cpufreq work

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-03 Thread Viresh Kumar
On 3 April 2014 18:10, Alexandre Oliva wrote: > FWIW, the same mistake is present in at32. I will check others as well now :) > I've just finished bisecting the cpufreq regression on loongson2. > Indeed, this s/static// patch does not fix it, but it was 652ed95d5fa, > the patch that moved

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-03 Thread Alexandre Oliva
On Apr 2, 2014, Viresh Kumar wrote: > did some changes to driver and by mistake made cpuclk as a 'static' local > variable, which wasn't actually required. Fix it. FWIW, the same mistake is present in at32. I've just finished bisecting the cpufreq regression on loongson2. Indeed, this

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-03 Thread Viresh Kumar
On 3 April 2014 18:10, Alexandre Oliva ol...@gnu.org wrote: FWIW, the same mistake is present in at32. I will check others as well now :) I've just finished bisecting the cpufreq regression on loongson2. Indeed, this s/static// patch does not fix it, but it was 652ed95d5fa, the patch that

Re: [PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-03 Thread Alexandre Oliva
On Apr 2, 2014, Viresh Kumar viresh.ku...@linaro.org wrote: did some changes to driver and by mistake made cpuclk as a 'static' local variable, which wasn't actually required. Fix it. FWIW, the same mistake is present in at32. I've just finished bisecting the cpufreq regression on loongson2.

[PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-01 Thread Viresh Kumar
Earlier commit: commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656 Author: Viresh Kumar Date: Thu Jan 9 20:38:43 2014 +0530 cpufreq: introduce cpufreq_generic_get() routine did some changes to driver and by mistake made cpuclk as a 'static' local variable,

[PATCH] cpufreq: loongson2_cpufreq: don't declare local variable as static

2014-04-01 Thread Viresh Kumar
Earlier commit: commit 652ed95d5fa6074b3c4ea245deb0691f1acb6656 Author: Viresh Kumar viresh.ku...@linaro.org Date: Thu Jan 9 20:38:43 2014 +0530 cpufreq: introduce cpufreq_generic_get() routine did some changes to driver and by mistake made cpuclk as a